go/src/pkg/database/sql/sql.go, branch main Fork of Go programming language with my patches. http://git.kilabit.info/go/atom?h=main 2014-09-08T04:08:51Z build: move package sources from src/pkg to src 2014-09-08T04:08:51Z Russ Cox rsc@golang.org 2014-09-08T04:08:51Z urn:sha1:c007ce824d9a4fccb148f9204e04c23ed2984b71 Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg. database/sql: Avoid re-preparing statements when all connections are busy 2014-09-02T16:08:41Z Marko Tiikkaja marko@joh.to 2014-09-02T16:08:41Z urn:sha1:90e2e2b89633770d42f2ff558588dfc53c3288c8 Previously, if all connections were busy, we would always re-prepare the statement on the connection we were assigned from the pool. That meant that if all connections were busy most of the time, the number of prepared statements for each connection would keep increasing over time. Instead, after getting a free connection, check to see if the statement has already been prepared on it, and reuse the statement handle if so. LGTM=bradfitz R=golang-codereviews, gobot, bradfitz CC=golang-codereviews https://golang.org/cl/116930043 database/sql: use a value type instead of a pointer 2014-08-28T18:07:29Z Brad Fitzpatrick bradfitz@golang.org 2014-08-28T18:07:29Z urn:sha1:558bd8e1d90e474c97115dd9d9cd089d19a3650f Follow-up to https://golang.org/cl/107020044/ Also add a little comment. LGTM=ruiu, josharian R=josharian, ruiu CC=golang-codereviews https://golang.org/cl/139760043 database/sql: use slices rather than container/list 2014-08-28T15:49:56Z Alberto García Hierro alberto@garciahierro.com 2014-08-28T15:49:56Z urn:sha1:6fb6f4e7f9eea8b724ddde592686d7e9dcdaa41c Significantly reduces the number of allocations, while also simplifying the code and increasing performance by a 1-2%. benchmark old ns/op new ns/op delta BenchmarkConcurrentDBExec 13290567 13026236 -1.99% BenchmarkConcurrentStmtQuery 13249399 13008879 -1.82% BenchmarkConcurrentStmtExec 8806237 8680182 -1.43% BenchmarkConcurrentTxQuery 13628379 12756293 -6.40% BenchmarkConcurrentTxExec 4794800 4722440 -1.51% BenchmarkConcurrentTxStmtQuery 5040804 5200721 +3.17% BenchmarkConcurrentTxStmtExec 1366574 1336626 -2.19% BenchmarkConcurrentRandom 11119120 10926113 -1.74% benchmark old allocs new allocs delta BenchmarkConcurrentDBExec 14191 13684 -3.57% BenchmarkConcurrentStmtQuery 16020 15514 -3.16% BenchmarkConcurrentStmtExec 4179 3672 -12.13% BenchmarkConcurrentTxQuery 16025 15518 -3.16% BenchmarkConcurrentTxExec 12717 12709 -0.06% BenchmarkConcurrentTxStmtQuery 15532 15525 -0.05% BenchmarkConcurrentTxStmtExec 2175 2168 -0.32% BenchmarkConcurrentRandom 12320 11997 -2.62% benchmark old bytes new bytes delta BenchmarkConcurrentDBExec 2164827 2139760 -1.16% BenchmarkConcurrentStmtQuery 2418070 2394030 -0.99% BenchmarkConcurrentStmtExec 1728782 1704371 -1.41% BenchmarkConcurrentTxQuery 2477144 2452620 -0.99% BenchmarkConcurrentTxExec 588920 588343 -0.10% BenchmarkConcurrentTxStmtQuery 790866 796578 +0.72% BenchmarkConcurrentTxStmtExec 98502 98143 -0.36% BenchmarkConcurrentRandom 1725906 1710220 -0.91% LGTM=ruiu, dave, bradfitz R=golang-codereviews, ruiu, gobot, bradfitz, dave, minux CC=bradfitz, golang-codereviews https://golang.org/cl/107020044 src, misc: applied gofmt -s -w 2014-07-16T23:29:51Z Robert Griesemer gri@golang.org 2014-07-16T23:29:51Z urn:sha1:8a23c0021edad5bbf117b71ee7db32406b0c9a67 Pending CL 113120043. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/112290043 database/sql: more docs explaining that DB is a pool 2014-05-19T16:54:47Z Brad Fitzpatrick bradfitz@golang.org 2014-05-19T16:54:47Z urn:sha1:7b103c555f9200eed9329f433378e72c7909e398 This is the main point of confusion and the emphasis of a recent Gophercon talk. Fixes #5886. (mostly fixed in previous commits) LGTM=r R=r CC=golang-codereviews https://golang.org/cl/100560043 database/sql: fix accounting of open connections 2014-05-07T18:54:29Z Brad Fitzpatrick bradfitz@golang.org 2014-05-07T18:54:29Z urn:sha1:ce6b75dab634e272e0449f85853fca7f1850da8b Existing test TestMaxOpenConns was failing occasionally, especially with higher values of GOMAXPROCS. Fixes #7532 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/95130043 all: spelling tweaks, A-G 2014-04-29T16:44:40Z Robert Hencke robert.hencke@gmail.com 2014-04-29T16:44:40Z urn:sha1:f999e14f025b69516dd3e126d04dd309adb2fce0 LGTM=ruiu, bradfitz R=golang-codereviews, bradfitz, ruiu CC=golang-codereviews https://golang.org/cl/91840044 database/sql: add "defer rows.Close()" to the example code. 2014-03-25T02:32:18Z Nigel Tao nigeltao@golang.org 2014-03-25T02:32:18Z urn:sha1:50ca1a52ca39bdd76bb5f999a67450f5984ebba2 Strictly speaking, it's not necessary in example_test.go, as the Rows.Close docs say that "If Next returns false, the Rows are closed automatically". However, if the for loop breaks or returns early, it's not obvious that you'll leak unless you explicitly call Rows.Close. LGTM=bradfitz R=bradfitz CC=golang-codereviews, rsc https://golang.org/cl/79330043 all: fix a few spelling errors in source comments 2013-12-27T16:59:02Z Martin Olsson martin@minimum.se 2013-12-27T16:59:02Z urn:sha1:5499034a7143d631e31b108b0c14c86c2345d458 R=golang-codereviews, dave, iant CC=golang-codereviews https://golang.org/cl/45750044