go/src/make.bash, branch json-isValidNumber

make.bash, make.rc: fix GOROOT detection when GOEXPERIMENT is set

2023-01-17T22:30:56Z

We need to clear GOEXPERIMENT any time we are invoking a bootstrap toolchain. One line missed the clearing of GOEXPERIMENT. There were three different lines using different syntaxes and subtly different sets of variables being cleared, so hoist them into a function so it's all in one place. Also quote $GOROOT_BOOTSTRAP consistently. Change-Id: I6c5a5d70c694c24705bbc61298b28ae906c0cf6c Reviewed-on: https://go-review.googlesource.com/c/go/+/456635 Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Run-TryBot: Russ Cox Auto-Submit: Russ Cox

all: use Go 1.17.13 for bootstrap

2022-10-17T19:46:59Z

Previously we used Go 1.17, but we realized thanks to tickling a pre-Go1.17.3 bug that if we are going to change the bootstrap toolchain that we should default to the latest available point release at the time we make the switch, not the initial major release, so as to avoid bugs that were fixed in the point releases. This CL updates the default search locations and the release notes. Users who run make.bash and depend on finding $HOME/sdk/go1.17 may need to run go install golang.org/dl/go1.17.13@latest go1.17.13 download to provide a Go 1.17.13 toolchain to their builds. Change-Id: I3a2511f088cf852470a7216a5a41ae775fb561b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/439419 Reviewed-by: Ian Lance Taylor Run-TryBot: Russ Cox Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot

build: update comments about Go 1.4 in make.bash, make.bat, make.rc

2022-08-15T18:40:54Z

A few lingering references to Go 1.4 remain. Fix them, and document the ones that should stay. For #44505. Fixes #54301. Change-Id: Ieb9c0f08e4d1890ea3fdfd9c8df5493934ae7493 Reviewed-on: https://go-review.googlesource.com/c/go/+/423354 TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov Run-TryBot: Russ Cox Reviewed-by: Dmitri Shuralyov

cmd/link: detect glibc vs musl ldso at link time

2022-08-08T21:12:57Z

Doing the test at link time lets us distribute one Linux toolchain that works on both glibc-based and musl-based Linux systems. The old way built a toolchain that only ran on one or the other. Fixes #54197. Change-Id: Iaae8c274c78e1091eee828a720b49646be9bfffe Reviewed-on: https://go-review.googlesource.com/c/go/+/420774 Auto-Submit: Russ Cox Reviewed-by: Cherry Mui TryBot-Result: Gopher Robot Run-TryBot: Russ Cox

cmd/dist: move more environment logic into cmd/dist from make and run scripts

2022-04-05T21:45:19Z

'go tool dist env' outputs different (and fewer) environment variables than 'go env'. The 'go tool dist env' variables should be authoritative, whereas many printed by 'go env' are merely informational (and not intended to be overridden in the actual environment). Fixes #52009 Change-Id: Ic0590153875183135cebf7ca55ead7c2b4038569 Reviewed-on: https://go-review.googlesource.com/c/go/+/398061 Trust: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot

make.bash: disable GOEXPERIMENT when using bootstrap toolchain

2022-04-04T21:06:39Z

When using Go 1.4 this doesn't matter, but when using Go 1.17, the bootstrap toolchain will complain about unknown GOEXPERIMENT settings. Clearly GOEXPERIMENT is for the toolchain being built, not the bootstrap. Already submitted as CL 395879 on the dev.boringcrypto branch, but needed on master to set up GOEXPERIMENT=boringcrypto builder ahead of merge. For #51940. Change-Id: Ib6a4099cca799b4d5df1974cdb5471adb0fd557d Reviewed-on: https://go-review.googlesource.com/c/go/+/397894 Trust: Russ Cox Run-TryBot: Russ Cox TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor

make.bash: document CC_FOR_${GOOS}_${GOARCH}

2022-04-04T17:35:32Z

Fixes #51306 Change-Id: I5989d86fe5ac4d02793b2ecb00c549d9586763da GitHub-Last-Rev: 6b0f6bee434219a2c502e8b5630fbe74ca25024a GitHub-Pull-Request: golang/go#51379 Reviewed-on: https://go-review.googlesource.com/c/go/+/388176 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gopher Robot Trust: Cherry Mui

build: force GOWORK=off in make.{bash,bat,rc}

2022-03-21T18:58:34Z

While building Go from source, workspace mode should be disabled, even if the external environment tries to configure it otherwise. Fixes #51558. Change-Id: Icd7577860271f59a8f94406214b111280e4b65b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/393879 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills Reviewed-by: Michael Matloob Auto-Submit: Dmitri Shuralyov

build: for default bootstrap, use Go 1.17 if present, falling back to Go 1.4

2021-12-08T16:50:04Z

Preparation for #44505, but safe for Go 1.18. Also fixes the default build on Macs, at least for people who have a $HOME/go1.17 or have run go install golang.org/dl/go1.17@latest go1.17 download Replay of CL 369914 after revert in CL 370138. Only change is adding 'export GOROOT_BOOTSTRAP' in make.bash. Change-Id: I8ced4e87a9dc0f05cc49095578b401ae6212ac85 Reviewed-on: https://go-review.googlesource.com/c/go/+/370274 Trust: Russ Cox Run-TryBot: Russ Cox Reviewed-by: Cuong Manh Le TryBot-Result: Gopher Robot

Revert "build: for default bootstrap, use Go 1.17 if present, falling back to Go 1.4"

2021-12-08T01:17:33Z

This reverts https://golang.org/cl/369914. Reason for revert: Breaking previously working toolchain builds. For #44505. Change-Id: I09ae20e50109a600d036358118077d27669df39c Reviewed-on: https://go-review.googlesource.com/c/go/+/370138 Reviewed-by: Dmitri Shuralyov Trust: Michael Pratt Run-TryBot: Michael Pratt TryBot-Result: Gopher Robot