go/src/cmd/compile/internal/inline/inl.go, branch json-isValidNumber-before

cmd/compile: change some unreachable code paths into Fatalf

2023-01-26T00:29:56Z

Now that GOEXPERIMENT=nounified is removed, we can assume InlineCall and HaveInlineBody will always be overridden with the unified frontend's implementations. Similarly, we can assume expandDecl will never be called. This CL changes the code paths into Fatalfs, so subsequent CLs can remove all the unreachable code. Updates #57410. Change-Id: I2a0c3edb32916c30dd63c4dce4f1bd6f18e07468 Reviewed-on: https://go-review.googlesource.com/c/go/+/458618 Auto-Submit: Matthew Dempsky TryBot-Result: Gopher Robot Reviewed-by: Keith Randall Run-TryBot: Matthew Dempsky Reviewed-by: Keith Randall

cmd/compile: remove -d=typecheckinl flag

2023-01-26T00:28:48Z

This flag forced the compiler to eagerly type check all available inline function bodies, which presumably was useful in the early days of implementing inlining support. However, it shouldn't have any significance with the unified frontend, since the same code paths are used for constructing normal function bodies as for inlining. Updates #57410. Change-Id: I6842cf86bcd0fbf22ac336f2fc0b7b8fe14bccca Reviewed-on: https://go-review.googlesource.com/c/go/+/458617 Reviewed-by: Keith Randall Run-TryBot: Matthew Dempsky Reviewed-by: Keith Randall Auto-Submit: Matthew Dempsky TryBot-Result: Gopher Robot

cmd: remove GOEXPERIMENT=nounified knob

2023-01-25T21:16:32Z

This CL removes the GOEXPERIMENT=nounified knob, and any conditional statements that depend on that knob. Further CLs to remove unreachable code follow this one. Updates #57410. Change-Id: I39c147e1a83601c73f8316a001705778fee64a91 Reviewed-on: https://go-review.googlesource.com/c/go/+/458615 Run-TryBot: Matthew Dempsky TryBot-Result: Gopher Robot Reviewed-by: Cherry Mui

cmd/compile: flag 'large' functions when -m=2+ in effect

2023-01-24T13:28:54Z

When -m=N (where N > 1) is in effect, include a note in the trace output if a given function is considered "big" during inlining analysis, since this causes the inliner to be less aggressive. If a small change to a large function happens to nudge it over the large function threshold, it can be confusing for developers, thus it's probably worth including this info in the remark output. Change-Id: Id31a1b76371ab1ef9265ba28a377f97b0247d0a7 Reviewed-on: https://go-review.googlesource.com/c/go/+/460317 Reviewed-by: Keith Randall TryBot-Result: Gopher Robot Run-TryBot: Than McIntosh Reviewed-by: Keith Randall

all: fix typos in go file comments

2023-01-20T03:27:26Z

This is the second round to look for spelling mistakes. This time the manual sifting of the result list was made easier by filtering out capitalized and camelcase words. grep -r --include '*.go' -E '^// .*$' . | aspell list | grep -E -x '[A-Za-z]{1}[a-z]*' | sort | uniq This PR will be imported into Gerrit with the title and first comment (this text) used to generate the subject and body of the Gerrit change. Change-Id: Ie8a2092aaa7e1f051aa90f03dbaf2b9aaf5664a9 GitHub-Last-Rev: fc2bd6e0c51652f13a7588980f1408af8e6080f5 GitHub-Pull-Request: golang/go#57737 Reviewed-on: https://go-review.googlesource.com/c/go/+/461595 Auto-Submit: Ian Lance Taylor TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Reviewed-by: Robert Griesemer

cmd/compile: simplify PGO hot caller/callee computation

2022-11-17T20:52:15Z

Currently, we use CDF to compute a weight threshold and then use the weight threshold to determine whether a call site is hot. As when we compute the CDF we already have a list of hot call sites that make up the given percentage of the CDF, just use that list. Also, when computing the CDF threshold, include the very last node that makes it to go over the threshold. (I.e. if the CDF threshold is 50% and one hot node takes 60% of weight, we should include that node instead of excluding it. In practice it rarely matters, probably only for testing and micro-benchmarks.) Change-Id: I535ae9cd6b679609e247c3d0d9ee572c1a1187cc Reviewed-on: https://go-review.googlesource.com/c/go/+/450737 Reviewed-by: Austin Clements TryBot-Result: Gopher Robot Run-TryBot: Cherry Mui

cmd/compile: adjust PGO inlining default parameters

2022-11-10T23:11:59Z

Adjust PGO inlining default parameters to 99% CDF threshold and 2000 budget. Benchmark results (mostly from Sweet) show that this set of parameters performs reasonably well, with a few percent speedup at the cost of a few percent binary size increase. Also rename the debug flags to start with "pgo", to make it clear that they are related to PGO. Change-Id: I0749249b1298d1dc55a28993c37b3185f9d7639d Reviewed-on: https://go-review.googlesource.com/c/go/+/449477 Run-TryBot: Cherry Mui Reviewed-by: Michael Pratt TryBot-Result: Gopher Robot

cmd/compile: fix transitive inlining of generic functions

2022-11-08T21:26:09Z

If an imported, non-generic function F transitively calls a generic function G[T], we may need to call CanInline on G[T]. While here, we can also take advantage of the fact that we know G[T] was already seen and compiled in an imported package, so we don't need to call InlineCalls or add it to typecheck.Target.Decls. This saves us from wasting compile time re-creating DUPOK symbols that we know already exist in the imported package's link objects. Fixes #56280. Change-Id: I3336786bee01616ee9f2b18908738e4ca41c8102 Reviewed-on: https://go-review.googlesource.com/c/go/+/443535 Run-TryBot: Matthew Dempsky TryBot-Result: Gopher Robot Reviewed-by: David Chase Auto-Submit: Matthew Dempsky

cmd/compile: adjust PGO debug output slightly

2022-11-08T18:10:43Z

- Include the callee names in hot call inlining message. - Print the graph when pgoinline >= 2. Change-Id: Iceb89b5f18cefc69ab9256aca9a910743d22ec0f Reviewed-on: https://go-review.googlesource.com/c/go/+/448496 TryBot-Result: Gopher Robot Run-TryBot: Cherry Mui Reviewed-by: Michael Pratt

cmd/compile: fix PGO line offset matching

2022-11-08T16:35:09Z

Appears to be a typo in CL 447315. Change-Id: I9f380a3c7521f5ac5a1d7e271eaa60bd4bbcfb29 Reviewed-on: https://go-review.googlesource.com/c/go/+/448515 Run-TryBot: Cherry Mui TryBot-Result: Gopher Robot Reviewed-by: Michael Pratt