go, branch json-isValidNumber

encoding/json: optimize isValidNumber function

2023-02-18T09:15:58Z

We use an index instead of reslicing the string because reslicing a string updates both the data and length fields instead of just the one index variable. Benchmark result, name old time/op new time/op delta NumberIsValid-8 19.0ns ± 0% 14.5ns ± 1% -23.70% (p=0.008 n=5+5) name old alloc/op new alloc/op delta NumberIsValid-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta NumberIsValid-8 0.00 0.00 ~ (all equal) Change-Id: I4698c5db134998f83ff47fb3add6a04ba6ec3aa0

runtime/cgo: restore correct build tags for linux/mips*

2023-02-18T05:22:26Z

The linux build tags were incorrectly removed from these files by CL 460538. Restore the correct build tags so that they are only included in builds for linux/mips* platforms. Change-Id: I21d8802b0252688d8e2228cf904b47d90b253485 Reviewed-on: https://go-review.googlesource.com/c/go/+/469175 Reviewed-by: Cherry Mui Run-TryBot: Joel Sing TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor

net/http: remove five second timeout from TestTransportClosesBodyOnError

2023-02-17T23:54:47Z

Wait forever and let the test time out with a stack trace if the expected response doesn't happen. Fixes #57990 Change-Id: I835def63db113752cdd06e03e258cb10d63a6a25 Reviewed-on: https://go-review.googlesource.com/c/go/+/463222 TryBot-Result: Gopher Robot Run-TryBot: Damien Neil Reviewed-by: Bryan Mills

cmd/compile: move raw writes out of write barrier code

2023-02-17T22:21:22Z

Previously, the write barrier calls themselves did the actual writes to memory. Instead, move those writes out to a common location that both the wb-enabled and wb-disabled code paths share. This enables us to optimize the write barrier path without having to worry about performing the actual writes. Change-Id: Ia71ab651908ec124cc33141afb52e4ca19733ac6 Reviewed-on: https://go-review.googlesource.com/c/go/+/447780 Reviewed-by: Michael Knyszek TryBot-Bypass: Keith Randall Run-TryBot: Keith Randall Reviewed-by: Cherry Mui

runtime: remove the restriction that write barrier ptrs come in pairs

2023-02-17T22:19:26Z

Future CLs will remove the invariant that pointers are always put in the write barrier in pairs. The behavior of the assembly code changes a bit, where instead of writing the pointers unconditionally and then checking for overflow, check for overflow first and then write the pointers. Also changed the write barrier flush function to not take the src/dst as arguments. Change-Id: I2ef708038367b7b82ea67cbaf505a1d5904c775c Reviewed-on: https://go-review.googlesource.com/c/go/+/447779 Run-TryBot: Keith Randall Reviewed-by: Cherry Mui Reviewed-by: Michael Knyszek TryBot-Bypass: Keith Randall

cmd/api: add API checks for freebsd/riscv64

2023-02-17T21:23:32Z

The freebsd/riscv64 port was added in go1.20, make cmd/api aware of it and backfill API files. For #58582 Change-Id: I242b161cdb6221c8f60a1868c6435be26fca0078 Reviewed-on: https://go-review.googlesource.com/c/go/+/469135 Run-TryBot: Dmitri Goutnik TryBot-Result: Gopher Robot Auto-Submit: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Reviewed-by: Bryan Mills

cmd/cgo: include seed string with -frandom-seed for lto

2023-02-17T20:39:34Z

cgo is built with -flto the symbols in runtime/cgo is going to include random numbers which would make builds unreproducible. Settings -frandom-seeds ensures this is consistent across builds, and to ensure we always use a reproducible seed across builds we use the actionID as the seed string. runtime/cgo built with "-frandom-seed=OFEc9OKoUMJwh3-5yFCH" would output the following: $ strings --all --bytes=8 $WORK/b055/_pkg_.a | grep "gnu.lto_.profile" .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 .gnu.lto_.profile.8403a797 Change-Id: I3c2d261a94f23c8227a922da9a7f81660905fd71 GitHub-Last-Rev: cec5162316d33d8f652948706ce0a5f8c6794a6e GitHub-Pull-Request: golang/go#58561 Reviewed-on: https://go-review.googlesource.com/c/go/+/468835 Reviewed-by: Bryan Mills Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot Run-TryBot: Bryan Mills Auto-Submit: Bryan Mills

cmd/api: add API checks for freebsd/arm64

2023-02-17T20:31:46Z

The freebsd/arm64 port was added in go1.14, make cmd/api aware of it and backfill API files. For #58582 Change-Id: I8b25c6cf5a66611d90d225762b257679a4abface Reviewed-on: https://go-review.googlesource.com/c/go/+/469115 Reviewed-by: Bryan Mills Auto-Submit: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Run-TryBot: Dmitri Goutnik Run-TryBot: Ian Lance Taylor TryBot-Result: Gopher Robot

test: add regress test for #58572

2023-02-17T03:59:20Z

Fixes #58572. Change-Id: I75fa432afefc3e036ed9a6a9002a29d7b23105ee Reviewed-on: https://go-review.googlesource.com/c/go/+/468880 Reviewed-by: Keith Randall TryBot-Result: Gopher Robot Reviewed-by: Cuong Manh Le Run-TryBot: Matthew Dempsky Auto-Submit: Matthew Dempsky

Revert "cmd/compile: use ONAME node directly from generated hash func"

2023-02-17T03:58:59Z

This reverts commit 25f5d9d4a253cb880bff909ebbdc05c8941c4a48. Causes ICE on valid code. Updates #58572. Change-Id: Ib276c87d9b0362bbd2a760ac2a242f82d4e20400 Reviewed-on: https://go-review.googlesource.com/c/go/+/468879 Reviewed-by: Cuong Manh Le Run-TryBot: Matthew Dempsky Auto-Submit: Matthew Dempsky Reviewed-by: Keith Randall TryBot-Result: Gopher Robot