go, branch go1.9rc1

[release-branch.go1.9] go1.9rc1

2017-07-24T19:35:04Z

Change-Id: I6251fc128990f9494a0b037cabb24ada5eabb6b5 Reviewed-on: https://go-review.googlesource.com/50951 Run-TryBot: Chris Broadfoot Reviewed-by: Brad Fitzpatrick Reviewed-by: Chris Broadfoot

[release-branch.go1.9] cmd/compile: consider exported flag in namedata

2017-07-24T18:12:06Z

It is possible to have an unexported name with a nil package, for an embedded field whose type is a pointer to an unexported type. We must encode that fact in the type..namedata symbol name, to avoid incorrectly merging an unexported name with an exported name. Fixes #21120 Change-Id: I2e3879d77fa15c05ad92e0bf8e55f74082db5111 Reviewed-on: https://go-review.googlesource.com/50710 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: David Crawshaw Reviewed-on: https://go-review.googlesource.com/50970 Reviewed-by: Chris Broadfoot

cmd/link: use full link, not compile, to test for -no-?pie

2017-07-24T17:50:57Z

This avoids an error from clang when using -nopie during compilation, and permits us to check that the entire build succeeds. Updates #21042 Change-Id: I2e6c7d5c97a85c223ed3288622bbb58ce33b8774 Reviewed-on: https://go-review.googlesource.com/50874 Run-TryBot: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick

.github: recommend 'go bug' when filing an issue

2017-07-24T17:18:34Z

It was released with 1.8, so it should be widely available. Change-Id: I7dcf205009b528071ea63f99cb5da0db183df341 Reviewed-on: https://go-review.googlesource.com/50932 Reviewed-by: Brad Fitzpatrick

.github: add SUPPORT file

2017-07-24T17:18:20Z

GitHub recently added support for a SUPPORT file: https://github.com/blog/2400-support-file-support This SUPPORT file is a very lightly edited copy of the wiki entry on asking questions: https://github.com/golang/go/wiki/Questions Change-Id: Ic1eb74d985ea30862defb99750fb42da84e492de Reviewed-on: https://go-review.googlesource.com/50930 Reviewed-by: Brad Fitzpatrick

encoding/json: ignore embedded fields of pointers to unexported non-structs

2017-07-22T01:29:58Z

https://golang.org/cl/33773 fixes the JSON marshaler to avoid serializing embedded fields on unexported types of non-struct types. However, Go allows embedding pointer to types, so the check for whether the field is a non-struct type must first dereference the pointer to get at the underlying type. Furthermore, due to a edge-case in the behavior of StructField.PkgPath not being a reliable indicator of whether the field is unexported (see #21122), we use our own logic to determine whether the field is exported or not. The logic in this CL may be simplified depending on what happens in #21122. Fixes #21121 Updates #21122 Change-Id: I8dfd1cdfac8a87950df294a566fb96dfd04fd749 Reviewed-on: https://go-review.googlesource.com/50711 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot

sync: delete a sentence from the Map docs

2017-07-21T22:00:47Z

From Josh's comments on https://golang.org/cl/50310 Once I removed the "from the Go standard library" bit, the beginning wasn't worth keeping. It also wasn't clear whether what it meant by "cache contention". Processor caches, or user-level caches built with sync.Map? It didn't seem worth clarifying and didn't convey any useful information, so deleted. Change-Id: Id1d76105a3081d0855f6a64540700932bb83d98e Reviewed-on: https://go-review.googlesource.com/50632 Reviewed-by: Josh Bleecher Snyder Reviewed-by: Bryan Mills

net/http: document that after Hijack, Request.Body is invalid

2017-07-21T18:55:41Z

We can make it panic with a more explicit and readable error message during Go 1.10, but document it for now. This has always been the case; it's not a new rule. Updates #20933 Change-Id: I53c1fefb47a8f4aae0bb32fa742afa3a2ed20e8a Reviewed-on: https://go-review.googlesource.com/50634 Reviewed-by: Ian Lance Taylor Reviewed-by: Emmanuel Odeke

sync: update Map documentation with usage rule of thumb

2017-07-21T16:02:43Z

As per bcmills’s lightning talk at GopherCon 2017: https://github.com/gophercon/2017-talks/tree/master/lightningtalks/BryanCMills-AnOverviewOfSyncMap Change-Id: I12dd0daa608af175d110298780f32c6dc5e1e0a0 Reviewed-on: https://go-review.googlesource.com/50310 Reviewed-by: Bryan Mills

doc: minor fixes to the editor guide

2017-07-21T15:39:05Z

Change-Id: I8f6bcfab27251ef6962306d56e40d306ef85fe60 Reviewed-on: https://go-review.googlesource.com/50472 Reviewed-by: Rob Pike