go, branch go1.6rc1

[release-branch.go1.6] cmd/newlink: remove from release branch

2016-01-28T00:06:14Z

Change-Id: Iec73b9a4279b5d6b458615c265e75b6becff320e Reviewed-on: https://go-review.googlesource.com/19023 Run-TryBot: Chris Broadfoot TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick

[release-branch.go1.6] go1.6rc1

2016-01-27T23:29:46Z

Change-Id: If8b5d7fd5f93d6aef2f746ae3cfd937b259be79e Reviewed-on: https://go-review.googlesource.com/19022 Reviewed-by: Brad Fitzpatrick

runtime: handle kindString in cgoCheckArg

2016-01-27T22:50:37Z

It's awkward to get a string value in cgoCheckArg, but SWIG testing revealed that it is possible. The new handling of extra files in the ptr.go test emulates what SWIG does with an exported function that returns a string. Change-Id: I453717f867b8a49499576c28550e7c93053a0cf8 Reviewed-on: https://go-review.googlesource.com/19020 Run-TryBot: Ian Lance Taylor Reviewed-by: Russ Cox

misc/cgo/test: disable sigaltstack test on darwin/386

2016-01-27T22:27:05Z

It doesn't work there ("out of memory") and doesn't really matter. Fixes build (now that we enable cgo on the darwin/386 builder.) Change-Id: I1d91e51ecb88c54eae39ac9a76f2c0b4e45263b0 Reviewed-on: https://go-review.googlesource.com/19004 Run-TryBot: Russ Cox Reviewed-by: Brad Fitzpatrick

runtime: deflake TestNumGoroutine

2016-01-27T22:17:42Z

Fixes #14107. Change-Id: Icd9463b1a77b139c7ebc2d8732482d704ea332d0 Reviewed-on: https://go-review.googlesource.com/19002 Reviewed-by: Brad Fitzpatrick

runtime/cgo: more +build cgo tags

2016-01-27T21:47:36Z

Followup to CL 19001. Change-Id: I7fa838b1ee8df53229e9dd29a231c2f9b2aa3f69 Reviewed-on: https://go-review.googlesource.com/19003 Reviewed-by: Brad Fitzpatrick

cmd/internal/obj/x86: skip test when GOHOSTARCH is set

2016-01-27T21:33:50Z

It's causing the darwin-386 builder to fail with: --- FAIL: TestDynlink (0.07s) obj6_test.go:118: error exit status 3 output go tool: no such tool "asm" FAIL FAIL cmd/internal/obj/x86 0.073s So skip it for now. It's tested in enough other places. Change-Id: I9a98ad7b8be807005750112d892ac6c676c17dd5 Reviewed-on: https://go-review.googlesource.com/18989 Run-TryBot: Brad Fitzpatrick Reviewed-by: Russ Cox

runtime/cgo: add cgo build tag to C files

2016-01-27T21:12:30Z

This makes "CGO_ENABLED=0 go list runtime/cgo" work, which fixes the current cmd/go test failure. Change-Id: Ia55ce3ba1dbb09f618ae5f4c8547722670360f59 Reviewed-on: https://go-review.googlesource.com/19001 Run-TryBot: Russ Cox Reviewed-by: Brad Fitzpatrick

runtime/race: run tests with GOMAXPROCS=1

2016-01-27T20:49:36Z

We set GOMAXPROCS=1 to prevent test flakiness. There are two sources of flakiness: 1. Some tests rely on particular execution order. If the order is different, race does not happen at all. 2. Ironically, ThreadSanitizer runtime contains a logical race condition that can lead to false negatives if racy accesses happen literally at the same time. Tests used to work reliably in the good old days of GOMAXPROCS=1. So let's set it for now. A more reliable solution is to explicitly annotate tests with required execution order by means of a special "invisible" synchronization primitive (that's what is done for C++ ThreadSanitizer tests). This is issue #14119. This reduces flakes on RaceAsFunc3 test from 60/3000 to 1/3000. Fixes #14086 Fixes #14079 Fixes #14035 Change-Id: Ibaec6b2b21e27b62563bffbb28473a854722cf41 Reviewed-on: https://go-review.googlesource.com/18968 Reviewed-by: Austin Clements Run-TryBot: Austin Clements Reviewed-by: Russ Cox TryBot-Result: Gobot Gobot

runtime: remove redundant empty function call from Breakpoint on arm

2016-01-27T19:45:14Z

CL 18964 included an extra patch (sorry, my first experience of git-codereview) which defined the conventional breakpoint instruction used by Plan 9 on arm, but also introduced a benign but unneeded call to runtime.emptyfunc. This CL removes the redundant call again. This completes the series of CLs which add support for Plan 9 on arm. Change-Id: Id293cfd40557c9d79b4b6cb164ed7ed49295b178 Reviewed-on: https://go-review.googlesource.com/19010 Reviewed-by: Brad Fitzpatrick