go, branch go1.6beta1

api: create go1.6.txt

2015-12-17T22:45:50Z

Change-Id: If2b30ab412d6799c8be01eb007462d6b58660ece Reviewed-on: https://go-review.googlesource.com/18014 Reviewed-by: Chris Broadfoot Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot

src: remove reference to since-deleted dist -s flag

2015-12-17T22:03:56Z

(Found while debugging release problems with go1.6beta1) Updates #12002 Change-Id: Iec197a754205e7fd28be154f27f17f3315886364 Reviewed-on: https://go-review.googlesource.com/18011 Reviewed-by: Chris Broadfoot

doc: change go1.6 http heading

2015-12-17T21:43:12Z

Change-Id: Iae05082530891175e9c86da244e610bc92759561 Reviewed-on: https://go-review.googlesource.com/17918 Reviewed-by: Chris Broadfoot

doc: Americanise spelling of wilful

2015-12-17T21:32:59Z

Fixes #13660 Change-Id: I05bcb4efcb865192a1ef6756e9dccef83505934c Reviewed-on: https://go-review.googlesource.com/17990 Reviewed-by: Chris Broadfoot

net/http: document ResponseWriter and Handler more; add test

2015-12-17T21:21:31Z

Update docs on ResponseWriter and Handler around concurrency. Also add a test. The Handler docs were old and used "object" a lot. It was also too ServeMux-centric. Fixes #13050 Updates #13659 (new issue found in http2 while writing the test) Change-Id: I25f53d5fa54f1c9d579d3d0f191bf3d94b1a251b Reviewed-on: https://go-review.googlesource.com/17982 Reviewed-by: Russ Cox Run-TryBot: Brad Fitzpatrick

cmd/link: reject non-package main toplevel.a file, remove dead code

2015-12-17T20:59:51Z

The test for non-package main top-level inputs is done while parsing the export data. Issue #13468 happened because we were not parsing the export data when using compiler-generated archives (that is, when using go tool compile -pack). Fix this by parsing the export data even for archives. However, that turns up a different problem: the export data check reports (one assumes spurious) skew errors now, because it has not been run since Go 1.2. (Go 1.3 was the first release to use go tool compile -pack.) Since the code hasn't run since Go 1.2, it can't be that important. Since it doesn't work today, just delete it. Figuring out how to make this code work with Robert's export format was one of the largest remaining TODOs for that format. Now we don't have to. Fixes #13468 and makes the world a better place. Change-Id: I40a4b284cf140d49d48b714bd80762d6889acdb9 Reviewed-on: https://go-review.googlesource.com/17976 Reviewed-by: Robert Griesemer

cmd/go: for go get -insecure, do not fall back to HTTP for non-200 responses

2015-12-17T20:28:14Z

Since we allow non-200 responses from HTTPS in normal operation, it seems odd to reject them in -insecure operation. Fixes #13037 (again). Change-Id: Ie232f7544ab192addfad407525888db6b967befe Reviewed-on: https://go-review.googlesource.com/17945 Reviewed-by: Brad Fitzpatrick

cmd/go: fix processing of HTTPS 404 without -insecure

2015-12-17T20:28:00Z

The change here is to move the closeBody call into the if block. The logging adjustments are just arranging to tell the truth: in particular if we're not in insecure mode and we get a non-200 error then we do not actually ignore the response (except as caused by closing the body incorrectly). As the comment below the change indicates, it is intentional that we process non-200 pages. The code does process them, because the if err != nil || status != 200 block does not return. But that block does close the body, which depending on timing can apparently poison the later read from the body. See #13037's initial report: $ go get -v bosun.org/cmd/bosun/cache Fetching https://bosun.org/cmd/bosun/cache?go-get=1 ignoring https fetch with status code 404 Parsing meta tags from https://bosun.org/cmd/bosun/cache?go-get=1 (status code 404) import "bosun.org/cmd/bosun/cache": parsing bosun.org/cmd/bosun/cache: http: read on closed response body package bosun.org/cmd/bosun/cache: unrecognized import path "bosun.org/cmd/bosun/cache" The log print about ignoring the https fetch is not strictly true, since the next thing that happened was parsing the body of that fetch. But the read on the closed response body failed during parsing. Moving the closeBody to happen only when we're about to discard the result and start over (that is, only in -insecure mode) fixes the parse. At least it should fix the parse. I can't seem to break the parse anymore, because of #13648 (close not barring future reads anymore), but this way is clearly better than the old way. If nothing else the old code closed the body twice when err != nil and -insecure was not given. Fixes #13037. Change-Id: Idf57eceb6d5518341a2f7f75eb8f8ab27ed4e0b4 Reviewed-on: https://go-review.googlesource.com/17944 Reviewed-by: Brad Fitzpatrick

Revert "cmd/go: allow omitted user name in git ssh repo syntax"

2015-12-17T20:25:42Z

This caused #13657. Reverting fixes #13657. I was trying to be helpful by fixing #12313, but I don't need the fix myself. Will leave for someone with more motivation. This reverts commit 3e9f0636709de7cd86a08785f2e64487580bf5ea. Change-Id: Ifc78a6196f23e0f58e3b9ad7340e207a2d5de0a6 Reviewed-on: https://go-review.googlesource.com/17977 Reviewed-by: Russ Cox

net/http: don't accept invalid bytes in server request headers

2015-12-17T20:22:08Z

Fixes #11207 Change-Id: I7f00b638e749fbc7907dc1597347ea426367d13e Reviewed-on: https://go-review.googlesource.com/17980 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Russ Cox