go, branch go1.5rc1

[release-branch.go1.5] cmd/newlink: remove from release branch

2015-08-06T04:06:12Z

Change-Id: Iad86bde6f2e0482745a4000ec4e192ade352983b Reviewed-on: https://go-review.googlesource.com/13292 Reviewed-by: Russ Cox Run-TryBot: Andrew Gerrand TryBot-Result: Gobot Gobot

[release-branch.go1.5] go1.5rc1

2015-08-06T03:32:40Z

Change-Id: Ibf98802b45cd22f20f8f3605bb695e9744b7a6b2 Reviewed-on: https://go-review.googlesource.com/13290 Reviewed-by: Russ Cox

net/url: allow all valid host chars in RawPath

2015-08-06T02:59:16Z

The old code was only allowing the chars we choose not to escape. We sometimes prefer to escape chars that do not strictly need it. Allowing those to be used in RawPath lets people override that preference, which is in fact the whole point of RawPath (new in Go 1.5). While we are here, also allow [ ] in RawPath. This is not strictly spec-compliant, but it is what modern browers do and what at least some people expect, and the [ ] do not cause any ambiguity (the usual reason they would be escaped, as they are part of the RFC gen-delims class). The argument for allowing them now instead of waiting until Go 1.6 is that this way RawPath has one fixed meaning at the time it is introduced, that we should not need to change or expand. Fixes #5684. Change-Id: If9c82a18f522d7ee1d10310a22821ada9286ee5c Reviewed-on: https://go-review.googlesource.com/13258 Reviewed-by: Andrew Gerrand

net/url: do not percent-encode valid host characters

2015-08-06T02:55:37Z

The code in question was added as part of allowing zone identifiers in IPv6 literals like http://[ipv6%zone]:port/foo, in golang.org/cl/2431. The old condition makes no sense. It refers to §3.2.1, which is the wrong section of the RFC, it excludes all the sub-delims, which §3.2.2 (the right section) makes clear are valid, and it allows ':', which is not actually valid, without an explanation as to why (because we keep :port in the Host field of the URL struct). The new condition allows all the sub-delims, as specified in RFC 3986, plus the additional characters [ ] : seen in IP address literals and :port suffixes, which we also keep in the Host field. This allows mysql://a,b,c/path to continue to parse, as it did in Go 1.4 and earlier. This CL does not break any existing tests, suggesting the over-conservative behavior was not intended and perhaps not realized. It is especially important not to over-escape the host field, because Go does not unescape the host field during parsing: it rejects any host field containing % characters. Fixes #12036. Change-Id: Iccbe4985957b3dc58b6dfb5dcb5b63a51a6feefb Reviewed-on: https://go-review.googlesource.com/13254 Reviewed-by: Andrew Gerrand Reviewed-by: Mikio Hara

doc/go1.5.html: fix typo

2015-08-06T02:55:27Z

Change-Id: Ic61fd38e7d2e0821c6adcaa210199a7dae8849a7 Reviewed-on: https://go-review.googlesource.com/13281 Reviewed-by: Andrew Gerrand

net/url: restrict :port checking to [ipv6]:port form

2015-08-06T02:55:03Z

Go 1.4 and earlier accepted mysql://x@y(z:123)/foo and I don't see any compelling reason to break that. The CL during Go 1.5 that broke this syntax was trying to fix #11208 and was probably too aggressive. I added a test case for #11208 to make sure that stays fixed. Relaxing the check did not re-break #11208 nor did it cause any existing test to fail. I added a test for the mysql://x@y(z:123)/foo syntax being preserved. Fixes #12023. Change-Id: I659d39f18c85111697732ad24b757169d69284fc Reviewed-on: https://go-review.googlesource.com/13253 Reviewed-by: Andrew Gerrand Reviewed-by: Mikio Hara

A+C: add Andy Maloney

2015-08-05T23:16:22Z

Fixes #10639 Change-Id: I0aa3bcbf656e23e6a110041439f6052057074b88 Reviewed-on: https://go-review.googlesource.com/13270 Reviewed-by: Russ Cox

cmd/go: fix handling of vendored imports in foo_test.go files

2015-08-05T23:13:19Z

Fixes #11977. Fixes #11988. Change-Id: I9f80006946d3752ee6d644ee51f2decfeaca1ff6 Reviewed-on: https://go-review.googlesource.com/13230 Reviewed-by: Andrew Gerrand Reviewed-by: Rob Pike

spec: clarify semantics of built-in functions 'complex', 'real', and 'imag'

2015-08-05T21:09:49Z

For #11669, #11540, #11945, #11946, #11947. Change-Id: Ifb0053c498cee9f3473c396f9338d82bd856c110 Reviewed-on: https://go-review.googlesource.com/12860 Reviewed-by: Russ Cox Reviewed-by: Rob Pike

crypto/tls: fix ConnectionState().VerifiedChains for resumed connection

2015-08-05T19:59:28Z

Strengthening VerifyHostname exposed the fact that for resumed connections, ConnectionState().VerifiedChains was not being saved and restored during the ClientSessionCache operations. Do that. This change just saves the verified chains in the client's session cache. It does not re-verify the certificates when resuming a connection. There are arguments both ways about this: we want fast, light-weight resumption connections (thus suggesting that we shouldn't verify) but it could also be a little surprising that, if the verification config is changed, that would be ignored if the same session cache is used. On the server side we do re-verify client-auth certificates, but the situation is a little different there. The client session cache is an object in memory that's reset each time the process restarts. But the server's session cache is a conceptual object, held by the clients, so can persist across server restarts. Thus the chance of a change in verification config being surprisingly ignored is much higher in the server case. Fixes #12024. Change-Id: I3081029623322ce3d9f4f3819659fdd9a381db16 Reviewed-on: https://go-review.googlesource.com/13164 Reviewed-by: Russ Cox Run-TryBot: Russ Cox Reviewed-by: Adam Langley