Fork of Go programming language with my patches. http://git.kilabit.info/go/atom?h=go1.4rc1 2014-11-17T02:55:59Z 2014-11-17T02:55:59Z Andrew Gerrand adg@golang.org 2014-11-17T02:55:59Z urn:sha1:30ef146819d031ccd875de806c4edad66366d4bc LGTM=dsymonds R=rsc, dsymonds CC=golang-codereviews https://golang.org/cl/179830043 2014-11-17T02:46:45Z Andrew Gerrand adg@golang.org 2014-11-17T02:46:45Z urn:sha1:daf5d4147118ed3f7bd4526cccf94301ed2f5cbf LGTM=dsymonds, minux R=rsc, dsymonds, minux CC=golang-codereviews https://golang.org/cl/176910043 2014-11-17T01:56:35Z Andrew Gerrand adg@golang.org 2014-11-17T01:56:35Z urn:sha1:c1fc059b080e82e46e5fd588acd370ed778d64cc ««« CL 174250043 / c16349455e05 debug/goobj: move to cmd/internal/goobj debug/goobj is not ready to be published but it is needed for the various binary-reading commands. Move to cmd/internal/goobj. (The Go 1.3 release branch deleted it, but that's not an option anymore due to the command dependencies. The API is still not vetted nor terribly well designed.) LGTM=adg, dsymonds R=adg, dsymonds CC=golang-codereviews https://golang.org/cl/174250043 »»» LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/177890043 2014-11-16T22:37:04Z Andrew Gerrand adg@golang.org 2014-11-16T22:37:04Z urn:sha1:335ad3db999a0ebcb9325f0ff300ea47ed7bd82c 2014-11-16T21:44:45Z Russ Cox rsc@golang.org 2014-11-16T21:44:45Z urn:sha1:b3932baba4e15e175e8f0e040d5e8bbd357a60d8 The SudoG used to sit on the stack, so it was cheap to allocated and didn't need to be cleaned up when finished. For the conversion to Go, we had to move sudog off the stack for a few reasons, so we added a cache of recently used sudogs to keep allocation cheap. But we didn't add any of the necessary cleanup before adding a SudoG to the new cache, and so the cached SudoGs had stale pointers inside them that have caused all sorts of awful, hard to debug problems. CL 155760043 made sure SudoG.elem is cleaned up. CL 150520043 made sure SudoG.selectdone is cleaned up. This CL makes sure SudoG.next, SudoG.prev, and SudoG.waitlink are cleaned up. I should have done this when I did the other two fields; instead I wasted a week tracking down a leak they caused. A dangling SudoG.waitlink can point into a sudogcache list that has been "forgotten" in order to let the GC collect it, but that dangling .waitlink keeps the list from being collected. And then the list holding the SudoG with the dangling waitlink can find itself in the same situation, and so on. We end up with lists of lists of unusable SudoGs that are still linked into the object graph and never collected (given the right mix of non-trivial selects and non-channel synchronization). More details in golang.org/issue/9110. Fixes #9110. LGTM=r R=r CC=dvyukov, golang-codereviews, iant, khr https://golang.org/cl/177870043 2014-11-16T19:25:33Z Russ Cox rsc@golang.org 2014-11-16T19:25:33Z urn:sha1:6150414cb8819ab9f054298ec7f8006a43ab8eea I just created that redirect, so we can change it once the wiki moves. LGTM=bradfitz, khr R=khr, bradfitz CC=golang-codereviews https://golang.org/cl/177780043 2014-11-14T06:03:17Z Nigel Tao nigeltao@golang.org 2014-11-14T06:03:17Z urn:sha1:f9d56543f1b3fe3b8da9dbda8892c4a9d2b8a312 LGTM=dsymonds R=dsymonds CC=golang-codereviews, nmvc https://golang.org/cl/169580043 2014-11-14T03:05:14Z Yasuhiro Matsumoto mattn.jp@gmail.com 2014-11-14T03:05:14Z urn:sha1:59439f8ea343ad79f289910d71d98dd6e6af8661 LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/170660043 2014-11-14T00:43:01Z Nigel Tao nigeltao@golang.org 2014-11-14T00:43:01Z urn:sha1:891abf9cc7c9c33e6afccbc3f6cbd5ef17a223b5 LGTM=bradfitz R=bradfitz, alex.brainman CC=golang-codereviews https://golang.org/cl/168600044 2014-11-12T22:27:27Z Brad Fitzpatrick bradfitz@golang.org 2014-11-12T22:27:27Z urn:sha1:38ea0ae05f1f2839949ca491a3541ada0e4c1211 Per private thread soliciting help. I realized part of this is documented in several places, but we lacked a unifying example. LGTM=rsc R=golang-codereviews CC=adg, golang-codereviews, iant, rsc https://golang.org/cl/171620043