go, branch go1.22.10

[release-branch.go1.22] go1.22.10

2024-12-03T18:00:04Z

Change-Id: I5e9be77389bcb215c114013c169841cfbcaa9550 Reviewed-on: https://go-review.googlesource.com/c/go/+/633235 LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov Reviewed-by: Veronica Silina Auto-Submit: Gopher Robot Reviewed-by: Michael Knyszek

[release-branch.go1.22] runtime: reserve 4kB for system stack on windows-386

2024-11-27T19:14:30Z

The failures in #70288 are consistent with and strongly imply stack corruption during fault handling, and debug prints show that the Go code run during fault handling is running about 300 bytes above the bottom of the goroutine stack. That should be okay, but that implies the DLL code that called Go's handler was running near the bottom of the stack too, and maybe it called other deeper things before or after the Go handler and smashed the stack that way. stackSystem is already 4096 bytes on amd64; making it match that on 386 makes the flaky failures go away. It's a little unsatisfying not to be able to say exactly what is overflowing the stack, but the circumstantial evidence is very strong that it's Windows. For #70288. Fixes #70474. Change-Id: Ife89385873d5e5062a71629dbfee40825edefa49 Reviewed-on: https://go-review.googlesource.com/c/go/+/627375 Reviewed-by: Ian Lance Taylor Auto-Submit: Russ Cox LUCI-TryBot-Result: Go LUCI (cherry picked from commit 7eeb0a188eb644486da9f77bae0375d91433d0bf) Reviewed-on: https://go-review.googlesource.com/c/go/+/632197 Reviewed-by: Cherry Mui Reviewed-by: Dmitri Shuralyov Auto-Submit: Veronica Silina

[release-branch.go1.22] syscall: mark SyscallN as noescape

2024-11-20T18:07:06Z

syscall.SyscallN is implemented by runtime.syscall_syscalln, which makes sure that the variadic argument doesn't escape. There is no need to worry about the lifetime of the elements of the variadic argument, as the compiler will keep them live until the function returns. For #70197 Fixes #70201 Change-Id: I12991f0be12062eea68f2b103fa0a794c1b527eb Reviewed-on: https://go-review.googlesource.com/c/go/+/625297 Reviewed-by: Ian Lance Taylor Reviewed-by: Alex Brainman Reviewed-by: David Chase LUCI-TryBot-Result: Go LUCI (cherry picked from commit 7fff741016c8157e107cce8013ee3ca621725384) Reviewed-on: https://go-review.googlesource.com/c/go/+/630215 Reviewed-by: Dmitri Shuralyov Reviewed-by: Quim Muntal Reviewed-by: Dmitri Shuralyov Auto-Submit: Ian Lance Taylor

[release-branch.go1.22] time: accept "+01" in TestLoadFixed on OpenBSD

2024-11-19T18:02:54Z

This stops the test from failing with a known failure mode, and creates time to look into what the next steps should be, if any. For #69840. Fixes #70238. Change-Id: I060903d256ed65c5dfcd70ae76eb361cab63186f Reviewed-on: https://go-review.googlesource.com/c/go/+/625197 Auto-Submit: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI Reviewed-by: Ian Lance Taylor Reviewed-by: Eric Grosse (cherry picked from commit bea9b91f0f4be730c880edbe496ab25c9b742cad) Reviewed-on: https://go-review.googlesource.com/c/go/+/627416 Reviewed-by: Dmitri Shuralyov Commit-Queue: Ian Lance Taylor Auto-Submit: Ian Lance Taylor

[release-branch.go1.22] go1.22.9

2024-11-06T22:47:22Z

Change-Id: I3255f216bc6976f9b5a1b1fc4f654caa2d2bc342 Reviewed-on: https://go-review.googlesource.com/c/go/+/626136 Auto-Submit: Gopher Robot Reviewed-by: Carlos Amedee LUCI-TryBot-Result: Go LUCI Reviewed-by: David Chase

[release-branch.go1.22] cmd/cgo/internal/testcarchive: remove 1-minute timeout

2024-10-31T20:50:59Z

The 1-minute test timeout seems a bit arbitrary. Use internal/testenv.Command, which applies t.Deadline to subcommand. For #67566. Fixes #70124. Change-Id: If84c96e353bdfaf02c9b123758198e031305ae32 Reviewed-on: https://go-review.googlesource.com/c/go/+/599056 LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov (cherry picked from commit 8c88f0c7365dc329506073e035f9609c36fe7020) Reviewed-on: https://go-review.googlesource.com/c/go/+/623595 Reviewed-by: Cherry Mui

[release-branch.go1.22] cmd/link: generate Mach-O UUID when -B flag is specified

2024-10-30T16:55:37Z

Currently, on Mach-O, the Go linker doesn't generate LC_UUID in internal linking mode. This causes some macOS system tools unable to track the binary, as well as in some cases the binary unable to access local network on macOS 15. This CL makes the linker start generate LC_UUID. Currently, the UUID is generated if the -B flag is specified. And we'll make it generate UUID by default in a later CL. The -B flag is currently for generating GNU build ID on ELF, which is a similar concept to Mach-O's UUID. Instead of introducing another flag, we just use the same flag and the same setting. Specifically, "-B gobuildid" will generate a UUID based on the Go build ID. Updates #68678. Fixes #69991. Cq-Include-Trybots: luci.golang.try:go1.22-darwin-amd64_14,go1.22-darwin-arm64_13 Change-Id: I90089a78ba144110bf06c1c6836daf2d737ff10a Reviewed-on: https://go-review.googlesource.com/c/go/+/618595 Reviewed-by: Michael Knyszek Reviewed-by: Ingo Oeser Reviewed-by: Than McIntosh LUCI-TryBot-Result: Go LUCI (cherry picked from commit 20ed60311848ca40e51cb430fa602dd83a9c726f) Reviewed-on: https://go-review.googlesource.com/c/go/+/622596 Auto-Submit: Michael Pratt Reviewed-by: Michael Pratt TryBot-Bypass: Michael Pratt

[release-branch.go1.22] runtime: fix TestGdbAutotmpTypes on gdb version 15

2024-10-02T16:24:02Z

On Arch Linux with gdb version 15.1, the test for TestGdbAutotmpTypes print the following output, ---- ~/src/go/src/runtime $ go test -run=TestGdbAutotmpTypes -v === RUN TestGdbAutotmpTypes === PAUSE TestGdbAutotmpTypes === CONT TestGdbAutotmpTypes runtime-gdb_test.go:78: gdb version 15.1 runtime-gdb_test.go:570: gdb output: Loading Go Runtime support. Target 'exec' cannot support this command. Breakpoint 1 at 0x46e416: file /tmp/TestGdbAutotmpTypes750485513/001/main.go, line 8. This GDB supports auto-downloading debuginfo from the following URLs: Enable debuginfod for this session? (y or [n]) [answered N; input not from terminal] Debuginfod has been disabled. To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit. [New LWP 355373] [New LWP 355374] [New LWP 355375] [New LWP 355376] Thread 1 "a.exe" hit Breakpoint 1, main.main () at /tmp/TestGdbAutotmpTypes750485513/001/main.go:8 8 func main() { 9 var iface interface{} = map[string]astruct{} All types matching regular expression "astruct": File runtime: []main.astruct bucket hash main.astruct typedef hash * map[string]main.astruct; typedef noalg.[8]main.astruct noalg.[8]main.astruct; noalg.map.bucket[string]main.astruct runtime-gdb_test.go:587: could not find []main.astruct; in 'info typrs astruct' output !!! FAIL exit status 1 FAIL runtime 0.273s $ ---- In the back trace for "File runtime", each output lines does not end with ";" anymore, while in test we check the string with it. While at it, print the expected string with "%q" instead of "%s" for better error message. For #67089 Fixes #69745 Change-Id: If6019ee68c0d8e495c920f98568741462c7d0fd0 Reviewed-on: https://go-review.googlesource.com/c/go/+/598135 Reviewed-by: David Chase Reviewed-by: Meng Zhuo LUCI-TryBot-Result: Go LUCI Reviewed-by: Michael Pratt (cherry picked from commit ff695ca2e3ea37dcb688d470e86ed64849c61f2e) Reviewed-on: https://go-review.googlesource.com/c/go/+/617456 Auto-Submit: Michael Knyszek Reviewed-by: Michael Knyszek

[release-branch.go1.22] go1.22.8

2024-10-01T17:24:31Z

Change-Id: I5436cd510a9fa232f7f50ed7e861bb02393e0117 Reviewed-on: https://go-review.googlesource.com/c/go/+/617020 LUCI-TryBot-Result: Go LUCI Auto-Submit: Gopher Robot Reviewed-by: David Chase Reviewed-by: Michael Knyszek

[release-branch.go1.22] syscall: skip TestAmbientCapsUserns when restricted, document

2024-09-11T22:13:15Z

For #67088 Fixes #69366 Change-Id: I42e7a8d02b161187772f147e3e136ab6e0f71d7f Reviewed-on: https://go-review.googlesource.com/c/go/+/585059 LUCI-TryBot-Result: Go LUCI Reviewed-by: Ian Lance Taylor (cherry picked from commit d05af626956af449fb13815cef06b606bc7740c6) Reviewed-on: https://go-review.googlesource.com/c/go/+/612475