go, branch go1.21rc2

[release-branch.go1.21] go1.21rc2

2023-06-21T15:40:05Z

Change-Id: I4a2c753f3edf22290e0e71a90df6d380fc009202 Reviewed-on: https://go-review.googlesource.com/c/go/+/504876 Reviewed-by: Dmitri Shuralyov Auto-Submit: Gopher Robot Run-TryBot: Gopher Robot TryBot-Bypass: Dmitri Shuralyov Reviewed-by: Michael Pratt Reviewed-by: Dmitri Shuralyov

[release-branch.go1.21] all: merge master (a7b1793) into release-branch.go1.21

2023-06-20T17:19:35Z

Merge List: + 2023-06-20 a7b1793701 cmd/go: do not index std as a module in modcache + 2023-06-20 3d279283a4 cmd/go: restore go.mod files during toolchain selection + 2023-06-20 3b4b7b84de cmd/distpack: rename go.mod to _go.mod in toolchain modules + 2023-06-20 6459494014 cmd/go: disable sumdb less often for toolchain downloads + 2023-06-20 02789816c4 internal/bisect: add 'q' hash option for quiet hash behavior switching + 2023-06-20 98617fd23f runtime/trace: add godoc links + 2023-06-19 bc21d6a4fc cmd/go/internal/modfetch: fix retractions slice initial length not zero + 2023-06-17 261e267618 os/exec: document a method to check if a process is alive + 2023-06-16 dbf9bf2c39 cmd/internal/moddeps: allow the "misc" module to be missing from GOROOT + 2023-06-16 0183c1aa02 cmd/compile/internal/syntax: skip GOROOT/misc in TestStdLib if it doesn't exist + 2023-06-16 199fbd4b59 cmd/internal/testdir: skip Test if GOROOT/test does not exist + 2023-06-16 a48f9c26d5 go/types: skip tests that require GOROOT/test if it is not present + 2023-06-16 3891ecbd35 go/internal/gcimporter: skip TestImportTypeparamTests if GOROOT/test is missing + 2023-06-16 60876717b4 cmd/go/internal/test: don't wait for previous test actions when interrupted + 2023-06-16 c1bc44642d path/filepath: avoid assuming that GOROOT/test is present + 2023-06-16 9ece9a7ac9 cmd/cgo/internal/testshared: disable gccgo tests on PPC64 + 2023-06-16 23c5e48c4a cmd/cgo/internal/testshared: strip newline from gccgo -dumpversion + 2023-06-16 cf7ae4f136 compress/bzip2: fix typo + 2023-06-16 3c8b7a9551 net/http: check RemoteAddr isn't nil before dereferencing + 2023-06-16 548790e64a net/http: close req.Body only when it's non-nil on js + 2023-06-16 6dc2d2aa6b testing/fstest: fix the Glob test when dir entries are out of order + 2023-06-16 2b0ff4b629 reflect: fix ArenaNew to match documentation + 2023-06-16 4eceefa338 cmd/distpack: make go_$GOOS_$GOARCH_exec programs executable + 2023-06-16 1a7709d6af runtime: use 1-byte load for address checking in racecallatomic + 2023-06-15 3e7ec13166 cmd/go: fix build config for 'go list -cover' + 2023-06-15 30b17f4f97 net/http: only disable Fetch API in tests + 2023-06-15 65db95d0ed math: document that Min/Max differ from min/max + 2023-06-15 60e6afb689 cmd/compile: do not report division by error during typecheck + 2023-06-15 f6e0dcc474 slices: add sort benchmark for sorted strings Change-Id: If342a000b719335fbbb421f027a8b253b07c1cab

cmd/go: do not index std as a module in modcache

2023-06-20T15:59:59Z

We do not index std as a whole module ever. When working in the main Go repo, files in package change often, so we don't want to pay the cost of reindexing all of std when what we really need is just to reindex strings. Per-package indexing works better for that case. When using a released Go toolchain, we don't have to worry about the whole module changing, but if we switch to whole-module indexing at that point, we have the potential for bugs that only happen in released toolchains. Probably not worth the risk. For similar reasons, we don't index the current work module as a whole module (individual packages are changing), so we use the heuristic that we only do whole-module indexing in the module cache. The new toolchain modules live in the module cache, though, and our heuristic was causing whole-module indexing for them. As predicted, enabling whole-module indexing for std when it's completely untested does in fact lead to bugs (a very minor one). This CL turns off whole-module indexing for std even when it is in the module cache, to bring toolchain module behavior back in line with the other ways to run toolchains. For #57001. Change-Id: I5012dc713f566846eb4b2848facc7f75bc956eb9 Reviewed-on: https://go-review.googlesource.com/c/go/+/504119 TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills Auto-Submit: Russ Cox Run-TryBot: Russ Cox

cmd/go: restore go.mod files during toolchain selection

2023-06-20T15:44:08Z

They have to be renamed to _go.mod to make a valid module. Copy them back to go.mod so that 'go test cmd' has a better chance of working. For #57001. Change-Id: Ied6f0dd77928996ab322a55c5606d7f75431e362 Reviewed-on: https://go-review.googlesource.com/c/go/+/504118 TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills Auto-Submit: Russ Cox Run-TryBot: Russ Cox

cmd/distpack: rename go.mod to _go.mod in toolchain modules

2023-06-20T15:03:07Z

Modules cannot contain go.mod files except at the root (and we don't keep one at the root). Rename the other go.mod files to _go.mod. dl2mod, which we used to convert all the old releases, did this renaming, but it was missed when porting that code to distpack. For #57001. Fixes #60847. Change-Id: I4d646b96b5be15df3b79193e254ddc9b11cc8734 Reviewed-on: https://go-review.googlesource.com/c/go/+/503979 Auto-Submit: Russ Cox Run-TryBot: Russ Cox Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills

cmd/go: disable sumdb less often for toolchain downloads

2023-06-20T15:02:47Z

There is a chicken and egg problem with always requiring the checksum database for toolchain module downloads, since the checksum database populates its entry by doing its own module download. Don't require the checksum database for GOPROXY=file:/// (for local testing) and when running on the Go module mirror. For #60847. Change-Id: I5d67d585169ae0fa73109df233baae8ba5fe5dd3 Reviewed-on: https://go-review.googlesource.com/c/go/+/503978 Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Auto-Submit: Russ Cox Run-TryBot: Russ Cox

internal/bisect: add 'q' hash option for quiet hash behavior switching

2023-06-20T14:35:37Z

This is intended for the specific case of 'fmahash=qn' where someone wants to disable fma without all the hash-search-handshake output. There are cases where arm64, ppc64, and s390x users might want to do this. Change-Id: Iaf46c68a00d7c9f7f82fd98a4548b72610f84bed Reviewed-on: https://go-review.googlesource.com/c/go/+/503776 Run-TryBot: David Chase Reviewed-by: Russ Cox TryBot-Result: Gopher Robot

runtime/trace: add godoc links

2023-06-20T00:47:09Z

Change-Id: I6db8ce8d7e0a1cb3d955493fa49eb7dff372eb38 Reviewed-on: https://go-review.googlesource.com/c/go/+/504375 Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Auto-Submit: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot

cmd/go/internal/modfetch: fix retractions slice initial length not zero

2023-06-19T20:30:05Z

When make slice of retractions, it should have initial length zero, to append more VersionIntervals. Currently without the zero length, the capacity used will be doubled after the appending, looks like a bug. Change-Id: Id3acaeffe557ca1d15c864b0377a66fee3a41f6c GitHub-Last-Rev: ed5fd5f6784c43195c531d8acc75560adff104ba GitHub-Pull-Request: golang/go#60354 Reviewed-on: https://go-review.googlesource.com/c/go/+/497118 Auto-Submit: Bryan Mills Reviewed-by: Bryan Mills Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov

os/exec: document a method to check if a process is alive

2023-06-17T19:02:45Z

Fixes #34396 Change-Id: I35c4e3447f84e349adf7edba92ccb19b324bfe14 GitHub-Last-Rev: 4f06764109ddd9bdfbe4841fc1bebebe026eeb29 GitHub-Pull-Request: golang/go#60763 Reviewed-on: https://go-review.googlesource.com/c/go/+/502815 TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor