go, branch go1.21.11

[release-branch.go1.21] go1.21.11

2024-06-04T18:11:01Z

Change-Id: I0c268e0b7f9493802e71bc4eebb2923e2d64713a Reviewed-on: https://go-review.googlesource.com/c/go/+/590417 LUCI-TryBot-Result: Go LUCI Reviewed-by: Michael Knyszek Auto-Submit: Gopher Robot Reviewed-by: Matthew Dempsky

[release-branch.go1.21] net/netip: check if address is v6 mapped in Is methods

2024-06-04T17:15:41Z

In all of the Is* methods, check if the address is a v6 mapped v4 address, and unmap it if so. Thanks to Enze Wang of Alioth (@zer0yu) and Jianjun Chen of Zhongguancun Lab (@chenjj) for reporting this issue. Fixes #67680 Fixes #67681 Fixes CVE-2024-24790 Change-Id: I6bd03ca1a5d93a0b59027d861c84060967b265b0 Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1460 Reviewed-by: Russ Cox Reviewed-by: Damien Neil (cherry picked from commit f7f270c1621fdc7ee48e0487b2fac0356947d19b) Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1500 Reviewed-by: Tatiana Bradley Reviewed-on: https://go-review.googlesource.com/c/go/+/590315 Auto-Submit: Michael Knyszek LUCI-TryBot-Result: Go LUCI Reviewed-by: David Chase

[release-branch.go1.21] os: RemoveAll: fix symlink race for unix

2024-05-30T00:12:19Z

Since all the platforms now support O_DIRECTORY flag for open, it can be used to (together with O_NOFOLLOW) to ensure we open a directory, thus eliminating the need to call stat before open. This fixes the symlink race, when a directory is replaced by a symlink in between stat and open calls. While at it, rename openFdAt to openDirAt, because this function is (and was) meant for directories only. NOTE Solaris supports O_DIRECTORY since before Solaris 11 (which is the only version Go supports since supported version now), and Illumos always had it. The only missing piece was O_DIRECTORY flag value, which is taken from golang.org/x/sys/unix. Fixes #67695. Change-Id: Ic1111d688eebc8804a87d39d3261c2a6eb33f176 Reviewed-on: https://go-review.googlesource.com/c/go/+/589057 Reviewed-by: Matthew Dempsky LUCI-TryBot-Result: Go LUCI Auto-Submit: Matthew Dempsky Reviewed-by: Carlos Amedee

[release-branch.go1.21] archive/zip: treat truncated EOCDR comment as an error

2024-05-29T23:37:27Z

When scanning for an end of central directory record, treat an EOCDR signature with a record containing a truncated comment as an error. Previously, we would skip over the invalid record and look for another one. Other implementations do not do this (they either consider this a hard error, or just ignore the truncated comment). This parser misalignment allowed presenting entirely different archive contents to Go programs and other zip decoders. For #66869 Fixes #67553 Change-Id: I94e5cb028534bb5704588b8af27f1e22ea49c7c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/585397 Reviewed-by: Joseph Tsai Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI (cherry picked from commit 33d725e5758bf1fea62e6c77fc70b57a828a49f5) Reviewed-on: https://go-review.googlesource.com/c/go/+/588795 Reviewed-by: Matthew Dempsky

[release-branch.go1.21] runtime: update large object stats before freeSpan in sweep

2024-05-24T20:52:56Z

Currently freeSpan is called before large object stats are updated when sweeping large objects. This means heapStats.inHeap might get subtracted before the large object is added to the largeFree field. The end result is that the /memory/classes/heap/unused:bytes metric, which subtracts live objects (alloc-free) from inHeap may overflow. Fix this by always updating the large object stats before calling freeSpan. For #67019. Fixes #67187. Change-Id: Ib02bd8dcd1cf8cd1bc0110b6141e74f678c10445 Reviewed-on: https://go-review.googlesource.com/c/go/+/583380 Auto-Submit: Michael Knyszek Reviewed-by: Felix Geisendörfer LUCI-TryBot-Result: Go LUCI Reviewed-by: Michael Pratt (cherry picked from commit 36d32f68f41561fb64677297e3733f5d5b866c2a) Reviewed-on: https://go-review.googlesource.com/c/go/+/584337

[release-branch.go1.21] crypto/x509: remove TestPlatformVerifierLegacy tests

2024-05-16T21:25:58Z

They are no longer necessary, woohoo! Updates #52108 Fixes #56791 Fixes #67351 Change-Id: I11a4c17162da4295309f74f2f8362bab0f506f78 Reviewed-on: https://go-review.googlesource.com/c/go/+/548976 Run-TryBot: Roland Shoemaker Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Auto-Submit: Roland Shoemaker LUCI-TryBot-Result: Go LUCI (cherry picked from commit c1828fbcbf8b8e18308e87bbac0d71244ec167f5) Reviewed-on: https://go-review.googlesource.com/c/go/+/586215 Reviewed-by: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov Auto-Submit: Dmitri Shuralyov

[release-branch.go1.21] cmd/go: set global .gitconfig location more robustly in tests

2024-05-16T01:44:02Z

Also confirm that setting the location actually worked before proceeding with the rest of the test. This fixes a test failure with git versions older than 2.32.0. For #53955. For #64603. Fixes #64586 Change-Id: I1a954975a3d8300e8b4dca045d3a15438a0407ec Reviewed-on: https://go-review.googlesource.com/c/go/+/548215 LUCI-TryBot-Result: Go LUCI Reviewed-by: Russ Cox Reviewed-by: Michael Matloob Run-TryBot: Bryan Mills Reviewed-on: https://go-review.googlesource.com/c/go/+/585816 Reviewed-by: Sam Thanawalla Reviewed-by: Dmitri Shuralyov Auto-Submit: Dmitri Shuralyov TryBot-Bypass: Dmitri Shuralyov

[release-branch.go1.21] cmd/go/internal/modfetch/codehost: add new git tags before statLocal instead of after

2024-05-16T01:41:07Z

gitRepo.statLocal reports tag and version information. If we are statting a hash that corresponds to a tag, we need to add that tag before calling statLocal so that it can be included in that information. For #53955. For #56881. For #64586 Change-Id: I69a71428e6ed9096d4cb8ed1bb79531415ff06c1 Reviewed-on: https://go-review.googlesource.com/c/go/+/547155 Auto-Submit: Bryan Mills LUCI-TryBot-Result: Go LUCI Reviewed-by: Michael Matloob (cherry picked from commit 7b5a3733fce46aa44449c5ba28876f5a1e630650) Reviewed-on: https://go-review.googlesource.com/c/go/+/585815 Reviewed-by: Sam Thanawalla Auto-Submit: Dmitri Shuralyov

[release-branch.go1.21] cmd/go/testdata/script: clear path in gotoolchain_issue66175

2024-05-13T21:10:38Z

The gotoolchain_issue66175 script test would fail if a binary named go1.21 or go1.22 was present in the system PATH. Clear the path at the beginning of the test to make it independent of the system path. For #67277 Fixes #67310 Change-Id: I6d9133aee5b20ab116e07b659e8ecf3eb8add4ed Reviewed-on: https://go-review.googlesource.com/c/go/+/584258 LUCI-TryBot-Result: Go LUCI Reviewed-by: Cherry Mui (cherry picked from commit a0a6026bb176d25401d7d188f95c1fe769d71db8) Reviewed-on: https://go-review.googlesource.com/c/go/+/584935 Auto-Submit: Dmitri Shuralyov

[release-branch.go1.21] cmd/compile: don't combine loads in generated equality functions

2024-05-10T15:30:28Z

... if the architecture can't do unaligned loads. We already handle this in a few places, but this particular place was added in CL 399542 and missed this additional restriction. Fixes #67164 (Reroll of CL 583303) Change-Id: Id067cc2e39d7d199672f2017f7f53991fb23f8d4 Reviewed-on: https://go-review.googlesource.com/c/go/+/583799 LUCI-TryBot-Result: Go LUCI Reviewed-by: Keith Randall Reviewed-by: Keith Randall