go, branch go1.18

[release-branch.go1.18] go1.18

2022-03-15T14:06:18Z

Change-Id: I81d8267b73c3dbd0d2f76e8c80fa2ae8b6f386df Reviewed-on: https://go-review.googlesource.com/c/go/+/392894 Trust: Heschi Kreinick Run-TryBot: Heschi Kreinick TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov

[release-branch.go1.18] doc: update go_spec.html with latest changes

2022-03-14T20:36:15Z

Generated at 2022-03-14 14:50 (EDT) with: git fetch git checkout origin/master -- doc/go_spec.html This includes spec changes up to CL 391754. Fixes #51532. Change-Id: I2c23d764ffa33f24647cd2a4060268c1500f6f99 Reviewed-on: https://go-review.googlesource.com/c/go/+/392674 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov TryBot-Result: Gopher Robot Reviewed-by: Heschi Kreinick

[release-branch.go1.18] cmd/compile: fix re-export closure

2022-03-14T17:19:04Z

For hidden closure built during stenciling to implement a function instantiation, the function may come from other package, not local package, which causes the ICE for code that re-export the hidden closure after inlining. To fix it, use the closure package for export writer when writing out the closure itself. Fixes #51423 Change-Id: I23b067ba14e2d602a0fc3b2e99bd9317afbe53ff Reviewed-on: https://go-review.googlesource.com/c/go/+/391574 Trust: Cuong Manh Le Run-TryBot: Cuong Manh Le Reviewed-by: Keith Randall TryBot-Result: Gopher Robot (cherry picked from commit 9743e9b6d8e150639f509fc64e4bc5f24ecce562) Reviewed-on: https://go-review.googlesource.com/c/go/+/391774 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Reviewed-by: Ian Lance Taylor

[release-branch.go1.18] internal/fuzz: minimization should not reduce coverage

2022-03-14T16:31:27Z

Minimization should result in a fuzz input which includes the same coverage bits as the original input. Updates #48326 Change-Id: I6c5f30058b57ccd1a096ad0e9452a4dfbb7d9aab Reviewed-on: https://go-review.googlesource.com/c/go/+/391454 Trust: Bryan Mills Reviewed-by: Roland Shoemaker Run-TryBot: Roland Shoemaker Auto-Submit: Roland Shoemaker TryBot-Result: Gopher Robot (cherry picked from commit 5003ed884a67ee26b4cedbe6f5b1c02bd5eb6630) Reviewed-on: https://go-review.googlesource.com/c/go/+/391798 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Reviewed-by: Bryan Mills

[release-branch.go1.18] internal/fuzz: don't use dirty coverage maps during minimization

2022-03-14T16:29:23Z

When minimizing a value, if the value cannot be minimized (i.e. it is the final value is the same value as was sent for minimization) return the initial coverage map, rather than the coverageSnapshot, which is actually the coverage map for the final minimization step and may not accurately reflect whether the input actually expands the coverage set or not. Updates #48326 Change-Id: I01f0eebe5841e808b6799647d2e5fe3aa45cd2e0 Reviewed-on: https://go-review.googlesource.com/c/go/+/391614 Reviewed-by: Bryan Mills Trust: Roland Shoemaker Run-TryBot: Roland Shoemaker Auto-Submit: Roland Shoemaker TryBot-Result: Gopher Robot (cherry picked from commit bd71dee2b4c0a44f9c32e9eb23d990b54ce06bae) Reviewed-on: https://go-review.googlesource.com/c/go/+/391797 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov

[release-branch.go1.18] go/types, types2: remove incorrect assertion (don't crash)

2022-03-14T16:24:26Z

The removed assertion was never incorrect, as signatures may be from methods in interfaces, and (some) interfaces set the receivers of their methods (so we have a position for error reporting). This CL changes the issue below from a release blocker to an issue for Go 1.19. For #51593. Change-Id: I0c5f2913b397b9ab557ed74a80cc7a715e840412 Reviewed-on: https://go-review.googlesource.com/c/go/+/391615 Trust: Robert Griesemer Run-TryBot: Robert Griesemer Reviewed-by: Robert Findley TryBot-Result: Gopher Robot (cherry picked from commit 914195c132cbec651aa43c409e8aac2614b53b38) Reviewed-on: https://go-review.googlesource.com/c/go/+/391796 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Reviewed-by: Robert Griesemer

[release-branch.go1.18] cmd/compile: fix expression switches using type parameters

2022-03-14T16:21:37Z

Both the thing we're switching on, as well as the cases we're switching for. Convert anything containing a type parameter to interface{} before the comparison happens. Fixes #51522 Change-Id: I97ba9429ed332cb7d4240cb60f46d42226dcfa5f Reviewed-on: https://go-review.googlesource.com/c/go/+/391594 Trust: Keith Randall Run-TryBot: Keith Randall TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Reviewed-by: Matthew Dempsky (cherry picked from commit 2e46a0a99768408c90cf4eeda3690831693fd8b2) Reviewed-on: https://go-review.googlesource.com/c/go/+/391795 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Reviewed-by: Keith Randall

[release-branch.go1.18] cmd/compile: fix transform of OEQ/ONE when one arg is a type param

2022-03-14T16:20:02Z

At this point in stenciling, we have shape types, not raw type parameters. The code was correct in the other part of this function. Update #51522 Change-Id: Ife495160a2be5f6af5400363c3efb68dda518b5f Reviewed-on: https://go-review.googlesource.com/c/go/+/391475 Trust: Keith Randall Run-TryBot: Keith Randall Reviewed-by: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor (cherry picked from commit 8cf11694abbfbdbd4fe0b2c08511f81b8bfe5017) Reviewed-on: https://go-review.googlesource.com/c/go/+/391794 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Reviewed-by: Keith Randall

[release-branch.go1.18] go/types, types2: pointer base types cannot be type constraints

2022-03-11T00:01:01Z

Pointer types may appear in expressions *P and we don't know if we have an indirection (P is a pointer value) or a pointer type (P is a type) until we type-check P. Don't forget to check that a type P must be an ordinary (not a constraint) type in this special case. Fixes #51578. Change-Id: If782cc6dd2a602a498574c78c99e40c3b72274a5 Reviewed-on: https://go-review.googlesource.com/c/go/+/391275 Trust: Robert Griesemer Run-TryBot: Robert Griesemer Reviewed-by: Robert Findley TryBot-Result: Gopher Robot (cherry picked from commit 3a5e3d8173df547d8360a609097fc80f01182db1) Reviewed-on: https://go-review.googlesource.com/c/go/+/391357 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Reviewed-by: Robert Griesemer

[release-branch.go1.18] go/types, types2: clarify documentation with respect to generic types

2022-03-11T00:00:29Z

Address several areas where documentation was inaccurate or unclear regarding generic types. Also prefer the use of the word 'generic' over 'parameterized', and add additional documentation for the use of SetConstraint. For #49593 Change-Id: Iccac60d1b3e2c45a57a3d03b3c10984293af57dd Reviewed-on: https://go-review.googlesource.com/c/go/+/391154 Trust: Robert Findley Run-TryBot: Robert Findley Reviewed-by: Robert Griesemer TryBot-Result: Gopher Robot (cherry picked from commit e189b5e06d4831025758c0b152838fa1a0375525) Reviewed-on: https://go-review.googlesource.com/c/go/+/391356 Trust: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov