go, branch go1.16.12

[release-branch.go1.16] go1.16.12

2021-12-09T13:44:57Z

Change-Id: I336b7203a30b17c738f1711dc4dc7654a3d17ed8 Reviewed-on: https://go-review.googlesource.com/c/go/+/370556 Trust: Alex Rakoczy Run-TryBot: Alex Rakoczy Reviewed-by: Filippo Valsorda TryBot-Result: Gopher Robot

[release-branch.go1.16] net/http: update bundled golang.org/x/net/http2

2021-12-09T13:10:36Z

Pull in security fix a5309b3 http2: cap the size of the server's canonical header cache Updates #50058 Fixes CVE-2021-44716 Change-Id: Ifdd13f97fce168de5fb4b2e74ef2060d059800b9 Reviewed-on: https://go-review.googlesource.com/c/go/+/370575 Trust: Filippo Valsorda Run-TryBot: Filippo Valsorda Reviewed-by: Alex Rakoczy TryBot-Result: Gopher Robot

[release-branch.go1.16] syscall: avoid writing to p when Pipe(p) fails

2021-12-09T12:28:59Z

Generally speaking Go functions make no guarantees about what has happened to result parameters on error, and Pipe is no exception: callers should avoid looking at p if Pipe returns an error. However, we had a bug in which ForkExec was using the content of p after a failed Pipe, and others may too. As a robustness fix, make Pipe avoid writing to p on failure. Updates #50057 Change-Id: Ie8955025dbd20702fabadc9bbe1d1a5ac0f36305 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1291271 Reviewed-by: Ian Lance Taylor Reviewed-on: https://go-review.googlesource.com/c/go/+/370515 Trust: Filippo Valsorda Run-TryBot: Filippo Valsorda TryBot-Result: Gopher Robot Reviewed-by: Alex Rakoczy

[release-branch.go1.16] syscall: fix ForkLock spurious close(0) on pipe failure

2021-12-09T12:28:55Z

Pipe (and therefore forkLockPipe) does not make any guarantees about the state of p after a failed Pipe(p). Avoid that assumption and the too-clever goto, so that we don't accidentally Close a real fd if the failed pipe leaves p[0] or p[1] set >= 0. Updates #50057 Fixes CVE-2021-44717 Change-Id: Iff8e19a6efbba0c73cc8b13ecfae381c87600bb4 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1291270 Reviewed-by: Ian Lance Taylor Reviewed-on: https://go-review.googlesource.com/c/go/+/370514 Trust: Filippo Valsorda Run-TryBot: Filippo Valsorda TryBot-Result: Gopher Robot Reviewed-by: Alex Rakoczy

Revert "[release-branch.go1.16] cmd/link: support more load commands on Mach-O"

2021-12-09T12:27:47Z

This reverts commit 98ef91b38e38289b8de07a77cad7a0c4208f0106. Reason for revert: Reducing risk for upcoming minor release. Change-Id: Ic18609383384ebbb49d144bcb17131077de390c2 Reviewed-on: https://go-review.googlesource.com/c/go/+/370554 Run-TryBot: Alex Rakoczy Reviewed-by: Filippo Valsorda Trust: Alex Rakoczy TryBot-Result: Gopher Robot

[release-branch.go1.16] cmd/link: support more load commands on Mach-O

2021-12-02T20:25:22Z

Fixes #49923. Change-Id: I74dd9170a51cc93ce3ec5e5860c2eb2912f081f5 Reviewed-on: https://go-review.googlesource.com/c/go/+/312729 Trust: Cherry Zhang Run-TryBot: Cherry Zhang Reviewed-by: Than McIntosh TryBot-Result: Go Bot (cherry picked from commit b6ff3c69d5fdf933f5265f95ae4bb12eaecc792f) Reviewed-on: https://go-review.googlesource.com/c/go/+/368835 Run-TryBot: Heschi Kreinick Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot Trust: Heschi Kreinick

[release-branch.go1.16] go1.16.11

2021-12-02T20:00:54Z

Change-Id: I2a6eb84b309b0793b5dd339a435764fb2d9c1fb8 Reviewed-on: https://go-review.googlesource.com/c/go/+/368694 Trust: Heschi Kreinick Trust: Michael Knyszek Run-TryBot: Heschi Kreinick Run-TryBot: Michael Knyszek Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot

[release-branch.go1.16] cmd/compile: only update source type when processing struct/array

2021-12-02T17:52:13Z

This is backport of CL 3651594, with the test from CL 360057. CL 360057 fixed missing update source type in storeArgOrLoad. However, we should only update the type when processing struct/array. If we update the type right before calling storeArgOrLoad, we may generate a value with invalid type, e.g, OpStructSelect with non-struct type. Fixes #49391 Change-Id: Ib7e10f72f818880f550aae5c9f653db463ce29b0 Reviewed-on: https://go-review.googlesource.com/c/go/+/361594 Trust: Cuong Manh Le Run-TryBot: Cuong Manh Le TryBot-Result: Go Bot Reviewed-by: David Chase Reviewed-on: https://go-review.googlesource.com/c/go/+/361597 TryBot-Result: Gopher Robot Reviewed-by: Keith Randall

[release-branch.go1.16] net/http: update bundled golang.org/x/net/http2

2021-12-02T04:43:33Z

Pull in approved backports to golang.org/x/net/http2: 64539c1 http2: don't count aborted streams as active in tests e677a40 ipv6: OpenBSD does not appear to support multicast loopback d8ae719 net/http2: Fix handling of expect continue cc2f99c http2: avoid busy loop when ResponseHeaderTimeout is set 5533dda http2: avoid spurious RoundTrip error when server closes and resets stream 26ec667 http2: close conns after use when req.Close is set By doing: $ go get -d golang.org/x/net@internal-branch.go1.16-vendor go: downloading golang.org/x/net v0.0.0-20211201233224-64539c132272 go get: upgraded golang.org/x/net v0.0.0-20211101194150-d8c3cde3c676 => v0.0.0-20211201233224-64539c132272 $ go mod tidy $ go mod vendor $ go generate -run=bundle std Fixes #49904. Fixes #49623. Fixes #49661. Fixes #49560. Fixes #49908. Fixes #49910. Change-Id: I73261b189f84cf1919a79129ec36a1c187723133 Reviewed-on: https://go-review.googlesource.com/c/go/+/368594 Trust: Michael Knyszek Run-TryBot: Michael Knyszek TryBot-Result: Go Bot Reviewed-by: Dmitri Shuralyov

[release-branch.go1.16] net/http/httptest: wait for user ConnState hooks

2021-12-01T22:15:01Z

Ensure that user ConnState callbacks have completed before returning from (*httptest.Server).Close. Fixes: #49851 Updates: #37510 Updates: #37505 Updates: #45237 Change-Id: I8fe7baa089fbe4f3836bf6ae9767c7b1270d1331 Reviewed-on: https://go-review.googlesource.com/c/go/+/304829 Trust: Damien Neil Run-TryBot: Damien Neil Reviewed-by: Bryan C. Mills (cherry picked from commit 5cec8b85e5dc75ef21b62efb6bd93f9007385e34) Reviewed-on: https://go-review.googlesource.com/c/go/+/367516 Trust: Bryan C. Mills Run-TryBot: Bryan C. Mills TryBot-Result: Go Bot Reviewed-by: Damien Neil