go, branch go1.14beta1

go/build: rename WorkingDir to Dir

2019-12-17T14:59:30Z

Fixes #36168 Change-Id: If2b7368671e83657a3a74dd030e66e7c68bf2361 Reviewed-on: https://go-review.googlesource.com/c/go/+/211657 Reviewed-by: Brad Fitzpatrick Reviewed-by: Jay Conrod

text/template: remove an incorrect comment and clarify docs for AddParseTree

2019-12-17T11:10:58Z

The comment "If the name is the name of this template, overwrite this template." is incorrect and should be "is not" instead. This comment is no longer required once the docs are updated to mention this behaviour instead. Fixes #34695 Change-Id: I773495b2194d7bb7619b13c1a28cbc76e8f69aac Reviewed-on: https://go-review.googlesource.com/c/go/+/199139 Reviewed-by: Rob Pike

time: further clarifications to the (*Timer).Stop docs

2019-12-17T00:18:33Z

Fixes #35627 Change-Id: I0c5fed46a69a9663e46a9414468ec610063ea05a Reviewed-on: https://go-review.googlesource.com/c/go/+/207849 Reviewed-by: Rob Pike

doc: remove Go Security Policy page (moved to x/website)

2019-12-16T20:38:31Z

This page has moved to the x/website repo in CL 211300 (commit golang/website@3c8b7f99cadaa000e642595d0fabcd9ac496f335). Remove the old copy in this repo since it's no longer used. Updates #29206 Change-Id: I8b3396d9e42d1e7262a8cde9577962d33b215836 Reviewed-on: https://go-review.googlesource.com/c/go/+/211301 Reviewed-by: Filippo Valsorda

api: promote next to go1.14

2019-12-16T20:22:12Z

Change-Id: I14b1a21a8639b3241326e74ab6152673d5d71243 Reviewed-on: https://go-review.googlesource.com/c/go/+/211517 Run-TryBot: Alexander Rakoczy Run-TryBot: Carlos Amedee TryBot-Result: Gobot Gobot Reviewed-by: Carlos Amedee Reviewed-by: Dmitri Shuralyov

runtime: do not use PowerRegisterSuspendResumeNotification on systems with "program time" timer

2019-12-16T17:37:20Z

Systems where PowerRegisterSuspendResumeNotification returns ERROR_ FILE_NOT_FOUND are also systems where nanotime() is on "program time" rather than "real time". The chain for this is: powrprof.dll!PowerRegisterSuspendResumeNotification -> umpdc.dll!PdcPortOpen -> ntdll.dll!ZwAlpcConnectPort("\\PdcPort") -> syscall -> ntoskrnl.exe!AlpcpConnectPort Opening \\.\PdcPort fails with STATUS_OBJECT_NAME_NOT_FOUND when pdc.sys hasn't been initialized. Pdc.sys also provides the various hooks for sleep resumption events, which means if it's not loaded, then our "real time" timer is actually on "program time". Finally STATUS_OBJECT_NAME_ NOT_FOUND is passed through RtlNtStatusToDosError, which returns ERROR_ FILE_NOT_FOUND. Therefore, in the case where the function returns ERROR_ FILE_NOT_FOUND, we don't mind, since the timer we're using will correspond fine with the lack of sleep resumption notifications. This applies, for example, to Docker users. Fixes #35447 Fixes #35482 Change-Id: I9e1ce5bbc54b9da55ff7a3918b5da28112647eee Reviewed-on: https://go-review.googlesource.com/c/go/+/208317 Reviewed-by: Jason A. Donenfeld Reviewed-by: Austin Clements Run-TryBot: Jason A. Donenfeld TryBot-Result: Gobot Gobot

go/doc: ignore example functions with arguments

2019-12-16T17:34:59Z

An Example function with arguments is not a valid example to be run with go test. Don't return those functions from Examples. This means that some functions that were previously showing up in Examples will no longer show up. But those functions were not being tested properly so the fact that they were showing up is misleading. This fixes an issue where a confusing compiler error was showing up when running go test on a file with an invalid example. While that issue could have been fixed by returning an error, this is more consistent with the behavior of go/doc.Examples, and the tests checker in vet will catch this issue. Fixes #35284 Change-Id: I2101a7d19f38522ef9c2e50967f9cfb30d28c730 Reviewed-on: https://go-review.googlesource.com/c/go/+/211357 Run-TryBot: Michael Matloob TryBot-Result: Gobot Gobot Reviewed-by: Jay Conrod

os/exec: ignore hungup error while copying stdin on Plan 9

2019-12-15T15:34:17Z

Fixes #35753 Change-Id: I38674c59c601785eb25b778dc25efdb92231dd9b Reviewed-on: https://go-review.googlesource.com/c/go/+/208223 Run-TryBot: Emmanuel Odeke TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick

spec: reword claim about the grammar being regular

2019-12-13T20:41:04Z

Since the word "regular" has a precise meaning in the context of formal languages, the Introduction sentence claiming that Go's grammar is "compact and regular" may mislead readers. Reword it using Rob's suggestion. Fixes #36037 Change-Id: I00c1a5714bdab8878d9a77b36d67dae67d63da0f Reviewed-on: https://go-review.googlesource.com/c/go/+/211277 Reviewed-by: Robert Griesemer Reviewed-by: Rob Pike

doc: fix missing closing tag in module documentation

2019-12-13T17:30:07Z

Updates #33637 Change-Id: If262d1501cf73b404361f832a2e3e17aaa0db78b Reviewed-on: https://go-review.googlesource.com/c/go/+/211299 Reviewed-by: Dmitri Shuralyov