go, branch go1.13rc1

[release-branch.go1.13] go1.13rc1

2019-08-21T19:21:42Z

Change-Id: I2921895d336c8f63e521b5c921494917b4f42f79 Reviewed-on: https://go-review.googlesource.com/c/go/+/191157 Run-TryBot: Andrew Bonventre Reviewed-by: Katie Hockman TryBot-Result: Gobot Gobot

Revert "encoding/json: avoid work when unquoting strings"

2019-08-21T15:20:00Z

This reverts CL 151157. CL 151157 introduced a crash when decoding into ",string" fields. It came with a moderate speedup, so at this stage of the release cycle let's just revert it, and reapply it in Go 1.14 with the fix in CL 190659. Also applied the test cases from CL 190659. Updates #33728 Change-Id: Ie46e2bc15224b251888580daf6b79d5865f3878e Reviewed-on: https://go-review.googlesource.com/c/go/+/190909 Run-TryBot: Andrew Bonventre TryBot-Result: Gobot Gobot Reviewed-by: Andrew Bonventre

cmd/go: accept GOSUMDB=sum.golang.google.cn

2019-08-21T15:13:03Z

This CL makes the go command understand that GOSUMDB=sum.golang.google.cn should connect to that domain but expect to find a checksum database signed by sum.golang.org there. The host sum.golang.google.cn is not yet completely configured; we hope it will be available in a few weeks. Change-Id: Ie0fc4323f0c7084dda59bd3b45fc406717fa16d9 Reviewed-on: https://go-review.googlesource.com/c/go/+/191137 Run-TryBot: Russ Cox Reviewed-by: Andrew Bonventre

doc/go1.13: mention '-o ' support for 'go build'

2019-08-20T21:00:50Z

Fixes #33720 Updates #14295 Change-Id: I9cb6e02bcaccd7971057315163d8810157d465bd Reviewed-on: https://go-review.googlesource.com/c/go/+/190907 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Jay Conrod

cmd/go: fix "go help build -o" docs

2019-08-20T19:26:11Z

The docs refer to "the last two paragraphs", but in fact should refer to the first two of the previous three paragraphs. Moved up the out of place paragraph. Updates #14295 Change-Id: I066da7a665bc6754d246782b941af214a385017a Reviewed-on: https://go-review.googlesource.com/c/go/+/190839 Reviewed-by: Bryan C. Mills Reviewed-by: Dmitri Shuralyov Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot

doc: rewrite reference to plan9.bell-labs.com to 9p.io

2019-08-19T21:42:54Z

Change-Id: I75619feced842b8ca509ee08e01b63258c5e87ca Reviewed-on: https://go-review.googlesource.com/c/go/+/190757 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot

encoding/json: fix format string in the Fuzz func

2019-08-18T01:16:33Z

Currently test build fails with: $ go test -tags=gofuzz encoding/json encoding/json/fuzz.go:36:4: Println call has possible formatting directive %s FAIL encoding/json [build failed] Change-Id: I23aef44a421ed0e7bcf48b74ac5a8c6768a4841b Reviewed-on: https://go-review.googlesource.com/c/go/+/190698 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor

time: update TestSub to avoid future regressions

2019-08-16T19:54:57Z

CL 131196 optimized Time.Sub, but was reverted because it incorrectly computed the nanoseconds in some edge cases. This CL adds a test case to enforce the correct behavior so that a future optimization does not break this again. Updates #17858 Updates #33677 Change-Id: I596d8302ca6bf721cf7ca11cc6f939639fcbdd43 Reviewed-on: https://go-review.googlesource.com/c/go/+/190524 Run-TryBot: Joe Tsai Reviewed-by: Daniel Martí Reviewed-by: Andrew Bonventre TryBot-Result: Gobot Gobot

cmd/gofmt: update TestRewrite to avoid future regressions

2019-08-16T19:54:55Z

CL 162337 changed go/ast to better handle block comments, but was reverted because it introduced an off-by-one bug. This CL adds a test case to enforce the correct behavior so that future changes do not break this again. Updates #18929 Updates #33538 Change-Id: I2d25c139d007f8db1091b7a48b1dd20c584e2699 Reviewed-on: https://go-review.googlesource.com/c/go/+/190523 Run-TryBot: Joe Tsai TryBot-Result: Gobot Gobot Reviewed-by: Robert Griesemer

Revert "time: optimize Sub"

2019-08-16T17:01:35Z

This reverts commit CL 131196 because there is a bug in the calculation of nanoseconds. Fixes #33677 Change-Id: Ic8e94c547ee29b8aeda1b9a5cb9764dbf47b14b4 Reviewed-on: https://go-review.googlesource.com/c/go/+/190497 Run-TryBot: Andrew Bonventre TryBot-Result: Gobot Gobot Reviewed-by: Emmanuel Odeke Reviewed-by: Andrew Bonventre