go, branch go1.13.6

[release-branch.go1.13] go1.13.6

2020-01-09T19:00:05Z

Change-Id: I8c0396849725345a12d4ca754f926714561fcc6e Reviewed-on: https://go-review.googlesource.com/c/go/+/214080 Run-TryBot: Carlos Amedee TryBot-Result: Gobot Gobot Reviewed-by: Alexander Rakoczy

[release-branch.go1.13] runtime: ensure memmove write pointer atomically on ARM64

2020-01-08T22:22:13Z

If a pointer write is not atomic, if the GC is running concurrently, it may observe a partially updated pointer, which may point to unallocated or already dead memory. Most pointer writes, like the store instructions generated by the compiler, are already atomic. But we still need to be careful in places like memmove. In memmove, we don't know which bits are pointers (or too expensive to query), so we ensure that all aligned pointer-sized units are written atomically. Fixes #36361. Updates #36101. Change-Id: I1b3ca24c6b1ac8a8aaf9ee470115e9a89ec1b00b Reviewed-on: https://go-review.googlesource.com/c/go/+/212626 Reviewed-by: Austin Clements (cherry picked from commit ffbc02761abb47106ce88e09290a31513b5f6c8a) Reviewed-on: https://go-review.googlesource.com/c/go/+/213683 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot

[release-branch.go1.13] net/http: avoid writing to Transport.ProxyConnectHeader

2020-01-07T20:29:45Z

Previously, we accidentally wrote the Proxy-Authorization header for the initial CONNECT request to the shared ProxyConnectHeader map when it was non-nil. Updates #36431 Fixes #36434 Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025 Reviewed-on: https://go-review.googlesource.com/c/go/+/213638 Run-TryBot: Bryan C. Mills Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot (cherry picked from commit 249c85d3aab2ad2d0bcbf36efe606fdd66f25c72) Reviewed-on: https://go-review.googlesource.com/c/go/+/213657

[release-branch.go1.13] runtime: do not use PowerRegisterSuspendResumeNotification on systems with "program time" timer

2020-01-03T23:38:58Z

Systems where PowerRegisterSuspendResumeNotification returns ERROR_ FILE_NOT_FOUND are also systems where nanotime() is on "program time" rather than "real time". The chain for this is: powrprof.dll!PowerRegisterSuspendResumeNotification -> umpdc.dll!PdcPortOpen -> ntdll.dll!ZwAlpcConnectPort("\\PdcPort") -> syscall -> ntoskrnl.exe!AlpcpConnectPort Opening \\.\PdcPort fails with STATUS_OBJECT_NAME_NOT_FOUND when pdc.sys hasn't been initialized. Pdc.sys also provides the various hooks for sleep resumption events, which means if it's not loaded, then our "real time" timer is actually on "program time". Finally STATUS_OBJECT_NAME_ NOT_FOUND is passed through RtlNtStatusToDosError, which returns ERROR_ FILE_NOT_FOUND. Therefore, in the case where the function returns ERROR_ FILE_NOT_FOUND, we don't mind, since the timer we're using will correspond fine with the lack of sleep resumption notifications. This applies, for example, to Docker users. Updates #35447 Updates #35482 Fixes #35746 Change-Id: I9e1ce5bbc54b9da55ff7a3918b5da28112647eee Reviewed-on: https://go-review.googlesource.com/c/go/+/211280 Run-TryBot: Jason A. Donenfeld TryBot-Result: Gobot Gobot Reviewed-by: Austin Clements Reviewed-by: Jason A. Donenfeld

[release-branch.go1.13] runtime: call goready in wakeScavenger instead of ready

2019-12-19T20:24:04Z

This changes fixes an oversight in wakeScavenger which would cause ready to be called off of the system stack. This change makes it so that wakeScavenger calls goready, which switches to the system stack before calling ready. Fixes #36127. Change-Id: Icb13f180b4d8fdd47c921eac1b896e3dd49e43b3 Reviewed-on: https://go-review.googlesource.com/c/go/+/200999 Run-TryBot: Michael Knyszek Reviewed-by: Keith Randall (cherry picked from commit 2c87be436bddd9b49f11959adee1ae817cb48ee1) Reviewed-on: https://go-review.googlesource.com/c/go/+/212103 TryBot-Result: Gobot Gobot Reviewed-by: Austin Clements

[release-branch.go1.13] cmd/go/internal/modfetch: remove non-hermetic test

2019-12-11T18:47:41Z

The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills Reviewed-by: Brad Fitzpatrick (cherry picked from commit f0390ffc9d461cb84207b5a94c4b645c87673406) Reviewed-on: https://go-review.googlesource.com/c/go/+/205438 Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot

[release-branch.go1.13] doc: add CherryPickApproved filter to Release History links

2019-12-09T19:53:51Z

Not all closed issues in a given minor milestone are included in that release, only the ones that have been labeled as CherryPickApproved are. Update the links to the GitHub issue tracker to include a filter on the CherryPickApproved label, so that the default view shows only the backports that were included in a given release. This should more useful to most people than seeing all backports (considered and approved). Do this only for Go 1.9.1 and newer releases, as that is when we started using the CherryPickCandidate and CherryPickApproved labels. Updates #35988 Fixes #36003 Change-Id: I51e07c1bc3ab9c4a5744e8f668c5470adf78bffe Reviewed-on: https://go-review.googlesource.com/c/go/+/210117 Run-TryBot: Dmitri Shuralyov Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot

[release-branch.go1.13] go1.13.5

2019-12-04T21:55:02Z

Change-Id: I700055da44126e2dfa56f371f9e208f4f727bbed Reviewed-on: https://go-review.googlesource.com/c/go/+/209898 Run-TryBot: Carlos Amedee Run-TryBot: Alexander Rakoczy Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot

[release-branch.go1.13] doc: fix typo in Go 1.12.14 document

2019-12-04T20:08:08Z

Change-Id: I3641a086f167a1337aaaacd2d758b6a42b84a7fb Reviewed-on: https://go-review.googlesource.com/c/go/+/209845 Run-TryBot: Carlos Amedee Run-TryBot: Alexander Rakoczy Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot (cherry picked from commit 98e7270a3d03c2741fc790ea619e5754c49e05ed) Reviewed-on: https://go-review.googlesource.com/c/go/+/209877

[release-branch.go1.13] doc: document Go 1.13.5

2019-12-04T20:07:53Z

Change-Id: I289d13ff0a01466d93ebc555eaa81273d4297eb4 Reviewed-on: https://go-review.googlesource.com/c/go/+/209841 Run-TryBot: Carlos Amedee Reviewed-by: Alberto Donizetti Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot (cherry picked from commit ebfe0574898c07e0a09a52390df1b282e2b176f7) Reviewed-on: https://go-review.googlesource.com/c/go/+/209843 Run-TryBot: Alexander Rakoczy