go, branch go1.12.5

[release-branch.go1.12] go1.12.5

2019-05-06T21:12:37Z

Change-Id: Ib253d4aafab3ad65b4ba666f4eeb8b2f245997a1 Reviewed-on: https://go-review.googlesource.com/c/go/+/175447 Run-TryBot: Andrew Bonventre Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot

[release-branch.go1.12] cmd/go/internal/imports: use the full path to resolve symlinks

2019-05-06T20:25:45Z

info.Name returns a name relative to the directory, so we need to prefix that directory in the Stat call. (This was missed in CL 141097 due to the fact that the test only happened to check symlinks in the current directory.) This allows the misc/ tests to work in module mode on platforms that support symlinks. Updates #30228 Updates #28107 Fixes #31763 Change-Id: Ie31836382df0cbd7d203b7a8b637c4743d68b6f3 Reviewed-on: https://go-review.googlesource.com/c/163517 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Jay Conrod Reviewed-on: https://go-review.googlesource.com/c/go/+/175441 Reviewed-by: Andrew Bonventre Reviewed-by: Brad Fitzpatrick

[release-branch.go1.12] doc: document Go 1.12.5

2019-05-06T20:12:17Z

Change-Id: I9986a323db2a8f5fa74b071cfd04e8c786da0cb3 Reviewed-on: https://go-review.googlesource.com/c/go/+/175438 Reviewed-by: Brad Fitzpatrick (cherry picked from commit 1560264f70a90de8d8b68e246c476d79e4d60574) Reviewed-on: https://go-review.googlesource.com/c/go/+/175444 Reviewed-by: Andrew Bonventre

[release-branch.go1.12] doc: document Go 1.11.10

2019-05-06T20:11:01Z

Change-Id: Icca4495f727e3921b717a4bbb441cd832d321d46 Reviewed-on: https://go-review.googlesource.com/c/go/+/175439 Reviewed-by: Brad Fitzpatrick (cherry picked from commit e1f9e701be094741b234320cc49b8776cce27c3f) Reviewed-on: https://go-review.googlesource.com/c/go/+/175443 Reviewed-by: Andrew Bonventre

[release-branch.go1.12] cmd/go/internal/get: fix strayed verbose output on stdout

2019-05-06T19:23:57Z

Fixes #31783 Change-Id: I3cc0ebc4be34d7c2d2d4fd655bfd0c2515ff3021 Reviewed-on: https://go-review.googlesource.com/c/go/+/174739 Reviewed-by: Jay Conrod Run-TryBot: Jay Conrod TryBot-Result: Gobot Gobot (cherry picked from commit fad365ba924291ce9994cb382191fc610984ed79) Reviewed-on: https://go-review.googlesource.com/c/go/+/175419 Run-TryBot: Andrew Bonventre Reviewed-by: Hyang-Ah Hana Kim Reviewed-by: Brad Fitzpatrick

[release-branch.go1.12] cmd/compile: use correct package name for stack object symbol

2019-05-06T18:53:43Z

Stack object generation code was always using the local package name for its symbol. Normally that doesn't matter, as we usually only compile functions in the local package. But for wrappers, the compiler generates functions which live in other packages. When there are two other packages with identical functions to wrap, the same name appears twice, and the compiler goes boom. Fixes #31396 Change-Id: I7026eebabe562cb159b8b6046cf656afd336ba25 Reviewed-on: https://go-review.googlesource.com/c/go/+/171464 Run-TryBot: Keith Randall TryBot-Result: Gobot Gobot Reviewed-by: Matthew Dempsky (cherry picked from commit 43001a0dc96a29f662f2782c5fb3ca998eadd623) Reviewed-on: https://go-review.googlesource.com/c/go/+/173317 Reviewed-by: Brad Fitzpatrick

[release-branch.go1.12] cmd/vet: add tests for point-release issues

2019-05-01T15:18:09Z

Add explicit tests for: #30465 cmd/vet: Consider reverting tag conflict for embedded fields #30399 cmd/vet: possible to get a printf false positive with big.Int because we have managed not to fix them in the last couple point releases, and it will be too embarrassing to do that yet again. Change-Id: Ib1da5df870348b6eb9bfc8a87c507ecc6d44b8dd Reviewed-on: https://go-review.googlesource.com/c/go/+/174520 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick

[release-branch.go1.12] cmd/vendor/golang.org/x/tools/go/analysis: update from release-branch.go1.12

2019-05-01T15:18:03Z

$ ./update-xtools.sh Copied /Users/rsc/src/golang.org/x/tools@aa829657 to . $ cd ~/src/golang.org/x/tools $ git log -n1 aa829657 commit aa82965741a9fecd12b026fbb3d3c6ed3231b8f8 (HEAD -> release-branch.go1.12, origin/release-branch.go1.12) Author: Daniel Martí AuthorDate: Fri Mar 1 11:00:19 2019 +0000 Commit: Brad Fitzpatrick CommitDate: Wed Mar 13 21:06:03 2019 +0000 ... $ Picks up cmd/vet fixes that have been inadvertently missed in point releases so far. Fixes #30399. Fixes #30465. Change-Id: Ibcfaac51d134205b986b32f857d54006b19c896a Reviewed-on: https://go-review.googlesource.com/c/go/+/174519 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick

Revert "runtime: scavenge memory upon allocating from scavenged memory"

2019-04-29T23:06:42Z

This reverts commit 8e093e7a1cd8a092f23717cb8f34bca489a3eee5 (CL 159500). Reason for revert: Increases memory allocation latency in certain situations. Fixes #31679. Change-Id: I15e02c53a58009fd907b619b8649de2cdeb29ef0 Reviewed-on: https://go-review.googlesource.com/c/go/+/174102 Run-TryBot: Michael Knyszek Reviewed-by: Austin Clements

[release-branch.go1.12] runtime: make mTreap.find actually find the best fit

2019-04-26T16:42:23Z

This change modifies the implementation of mTreap.find to find the best-fit span with the lowest possible base address. Fixes #31677. Change-Id: Ib4bda0f85d7d0590326f939a243a6e4665f37d3f Reviewed-on: https://go-review.googlesource.com/c/go/+/173479 Run-TryBot: Michael Knyszek TryBot-Result: Gobot Gobot Reviewed-by: Austin Clements (cherry picked from commit 8c05d67661c966f5130e51ca685b0c70a5a929ff) Reviewed-on: https://go-review.googlesource.com/c/go/+/173939 Reviewed-by: Brad Fitzpatrick