go, branch go1.12.14

[release-branch.go1.12] go1.12.14

2019-12-04T21:35:28Z

Change-Id: I3f3fcee395bd3f9bdb6ad4028506ac90fb84c388 Reviewed-on: https://go-review.googlesource.com/c/go/+/209897 Run-TryBot: Carlos Amedee Run-TryBot: Alexander Rakoczy Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot

[release-branch.go1.12] doc: fix typo in Go 1.12.14 document

2019-12-04T19:59:50Z

Change-Id: I3641a086f167a1337aaaacd2d758b6a42b84a7fb Reviewed-on: https://go-review.googlesource.com/c/go/+/209845 Run-TryBot: Carlos Amedee Run-TryBot: Alexander Rakoczy Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot (cherry picked from commit 98e7270a3d03c2741fc790ea619e5754c49e05ed) Reviewed-on: https://go-review.googlesource.com/c/go/+/209846

[release-branch.go1.12] doc: document Go 1.12.14

2019-12-04T19:27:30Z

Change-Id: I7589ef4bdac776c8f141e9cc60f59f8643649310 Reviewed-on: https://go-review.googlesource.com/c/go/+/209840 Reviewed-by: Alexander Rakoczy Run-TryBot: Alexander Rakoczy TryBot-Result: Gobot Gobot (cherry picked from commit f805b05b39a28a85017df4540f1770f0d833e3d2) Reviewed-on: https://go-review.googlesource.com/c/go/+/209842 Run-TryBot: Carlos Amedee

[release-branch.go1.12] runtime: fix textOff for multiple text sections

2019-12-04T17:11:12Z

If a compilation has multiple text sections, code in textOff must compare the offset argument against the range for each text section to determine which one it is in. The comparison looks like this: if uintptr(off) >= sectaddr && uintptr(off) <= sectaddr+sectlen If the off value being compared is equal to sectaddr+sectlen then it is not within the range of the text section but after it. The comparison should be just '<'. Fixes #35210 Change-Id: I114633fd734563d38f4e842dd884c6c239f73c95 Reviewed-on: https://go-review.googlesource.com/c/go/+/203817 Run-TryBot: Lynn Boger TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor Reviewed-by: Cherry Zhang (cherry picked from commit 0ae9389609f23dc905c58fc2ad7bcc16b770f337) Reviewed-on: https://go-review.googlesource.com/c/go/+/203818 Run-TryBot: Carlos Amedee Reviewed-by: Keith Randall

[release-branch.go1.12] cmd/vendor: remove _test.go and testdata files

2019-11-22T17:29:31Z

Binary files included in testdata directories can cause Apple’s notarization service to reject us since they don’t abide by their strict requirements. To emulate go mod vendor, remove all _test.go and testdata files from the vendor directory and update the instructions. Updates #34986 Fixes #35747 Change-Id: I5cde905fc78838d2e3b1519dab4aeee13d8d5356 Reviewed-on: https://go-review.googlesource.com/c/go/+/208227 Run-TryBot: Andrew Bonventre TryBot-Result: Gobot Gobot Reviewed-by: Alexander Rakoczy

[release-branch.go1.12] all: base64-encode binaries that will cause Apple notarization to fail

2019-11-21T17:36:20Z

Starting with macOS 10.15 (Catalina), Apple now requires all software distributed outside of the App Store to be notarized. Any binaries we distribute must abide by a strict set of requirements like code-signing and having a minimum target SDK of 10.9 (amongst others). Apple’s notarization service will recursively inspect archives looking to find notarization candidate binaries. If it finds a binary that does not meet the requirements or is unable to decompress an archive, it will reject the entire distribution. From cursory testing, it seems that the service uses content sniffing to determine file types, so changing the file extension will not work. There are some binaries and archives included in our distribution that are being detected by Apple’s service as potential candidates for notarization or decompression. As these are files used by tests and some are intentionally invalid, we don’t intend to ever make them compliant. As a workaround for this, we base64-encode any binaries or archives that Apple’s notarization service issues a warning for, as these warnings will become errors in January 2020. Updates #34986 Updates #35747 Change-Id: I106fbb6227b61eb221755568f047ee11103c1680 Reviewed-on: https://go-review.googlesource.com/c/go/+/208118 Run-TryBot: Andrew Bonventre TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick (cherry picked from commit 8bbfc51d9ac9ce9472e126cc3654c9a45eceb236) Reviewed-on: https://go-review.googlesource.com/c/go/+/208220 Reviewed-by: Alexander Rakoczy

[release-branch.go1.12] go1.12.13

2019-10-31T22:53:22Z

Change-Id: Ic4db4625c4b7031aa08cb235f526267058a50430 Reviewed-on: https://go-review.googlesource.com/c/go/+/204641 Run-TryBot: Andrew Bonventre TryBot-Result: Gobot Gobot Reviewed-by: Alexander Rakoczy

[release-branch.go1.12] doc: document Go 1.12.13

2019-10-31T21:53:06Z

Change-Id: Ic65a74e56320adbd76aeef1cf3b19d7906ffe8fe Reviewed-on: https://go-review.googlesource.com/c/go/+/204639 Run-TryBot: Andrew Bonventre Reviewed-by: Dmitri Shuralyov TryBot-Result: Gobot Gobot

[release-branch.go1.12] go1.12.12

2019-10-17T21:51:57Z

Change-Id: I3494e831beac93e322788f7bd76948b52f769f37 Reviewed-on: https://go-review.googlesource.com/c/go/+/201822 Run-TryBot: Alexander Rakoczy TryBot-Result: Gobot Gobot Reviewed-by: Katie Hockman

[release-branch.go1.12] doc: document Go 1.12.12

2019-10-17T21:06:37Z

Change-Id: I832ba5f32d513b586bb0b02371231786b25631e3 Reviewed-on: https://go-review.googlesource.com/c/go/+/201817 Reviewed-by: Andrew Bonventre (cherry picked from commit 58e8f7897a0b69fee891af8461e1270d59f4d1a6) Reviewed-on: https://go-review.googlesource.com/c/go/+/201821