go, branch go1.11beta1

cmd/compile: improve escape analysis explanation

2018-06-26T20:00:51Z

No code changes, only revised comments in an attempt to make escape analysis slightly less confusing. Updates #23109. Change-Id: I5ee6cea0946ced63f6210ac4484a088bcdd862fb Reviewed-on: https://go-review.googlesource.com/121001 Run-TryBot: David Chase TryBot-Result: Gobot Gobot Reviewed-by: Cherry Zhang

ast: refer to "embedded" rather than "anonymous" fields in

2018-06-26T19:40:44Z

documentation. Fixes #25684. Change-Id: I9d0e47dff2446c27a3df88fb9ccfefef7419470b Reviewed-on: https://go-review.googlesource.com/120556 Reviewed-by: Robert Griesemer

go/types: rename NewInterface2 to NewInterfaceType

2018-06-26T17:31:34Z

NewInterface2 was introduced with https://go-review.googlesource.com/114317 which fixed #25301. Changed the name to NewInterfaceType to better match Go naming styles, per discussion with @josharian, @iant, et al. Change-Id: Ifa4708a5efd4f708295b33c3d20fdc5812e1b4fc Reviewed-on: https://go-review.googlesource.com/120875 Reviewed-by: Josh Bleecher Snyder Reviewed-by: Ian Lance Taylor

syscall/js: use stable references to JavaScript values

2018-06-26T16:40:09Z

This commit changes how JavaScript values are referenced by Go code. After this change, a JavaScript value is always represented by the same ref, even if passed multiple times from JavaScript to Go. This allows Go's == operator to work as expected on js.Value (strict equality). Additionally, the performance of some operations of the syscall/js package got improved by saving additional roundtrips to JavaScript code. Fixes #25802. Change-Id: Ide6ffe66c6aa1caf5327a2d3ddbe48fe7c180461 Reviewed-on: https://go-review.googlesource.com/120561 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick

syscall: fix typo in RawSyscall6 comment

2018-06-26T14:41:15Z

Change-Id: I589a60459a3b0811da77d46428eca57c741b1184 GitHub-Last-Rev: f9ab775b9d7f869916af6de9abb7c1d5f0005f1b GitHub-Pull-Request: golang/go#26063 Reviewed-on: https://go-review.googlesource.com/120917 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot

cmd/cgo: mention character restrictions on #cgo lines

2018-06-26T14:39:02Z

Fixes #26025 Change-Id: I43b3c9019ca8d2844e4d664c2090e506b2171077 Reviewed-on: https://go-review.googlesource.com/120975 Reviewed-by: Brad Fitzpatrick

time: run genzabbrs.go to update zoneinfo_abbrs_windows.go

2018-06-26T09:55:39Z

The abbreviations list in zoneinfo_abbrs_windows.go was last updated in June 2017, and it's currently outdated. Update it. Change-Id: Ie2bf4268787f5aefe98ee110c2c279451e18fd97 Reviewed-on: https://go-review.googlesource.com/120559 Run-TryBot: Alberto Donizetti TryBot-Result: Gobot Gobot Reviewed-by: Alex Brainman

cmd/compile: map delete should clear value always

2018-06-26T01:57:01Z

Map delete must clear value every time because newly added map optimizations of compound-assignment operators (CL #91557) rely on this behavior of map delete. It slows down map delete operation for non-reference types: name old time/op new time/op delta MapDelete/Int32/100 23.9ns ± 2% 27.8ns ± 4% +16.04% (p=0.000 n=20+20) MapDelete/Int32/1000 21.5ns ± 2% 25.2ns ± 2% +17.06% (p=0.000 n=20+19) MapDelete/Int32/10000 24.2ns ± 6% 27.2ns ± 5% +12.39% (p=0.000 n=19+19) MapDelete/Int64/100 24.2ns ± 4% 27.7ns ± 2% +14.55% (p=0.000 n=20+20) MapDelete/Int64/1000 22.1ns ± 2% 24.8ns ± 2% +12.36% (p=0.000 n=10+20) Fixes #25936 Change-Id: I8499b790cb5bb019938161b3e50f3243d9bbb79c Reviewed-on: https://go-review.googlesource.com/120255 Run-TryBot: Emmanuel Odeke Reviewed-by: Keith Randall

cmd/dist: increase timeout scale to 3 for windows

2018-06-25T20:52:59Z

cmd/go can sometimes take up to 400s on windows due to various issues (disk I/O on builders being the latest cause). Increase the timeout scale to account for this. Change-Id: I1fd4964472a70fb0f33cf6ed73298c034b9c1fb0 Reviewed-on: https://go-review.googlesource.com/120762 Run-TryBot: Andrew Bonventre Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot

cmd/compile: avoid remainder in loopbce when increment=0

2018-06-25T20:36:42Z

For non-unit increment, loopbce checks to see if the increment evenly divides the difference between (constant) loop start and end. This test panics when the increment is zero. Fix: check for zero, if found, don't optimize the loop. Also added missing copyright notice to loopbce.go. Fixes #26043. Change-Id: I5f460104879cacc94481949234c9ce8c519d6380 Reviewed-on: https://go-review.googlesource.com/120759 Run-TryBot: David Chase TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick