go, branch go1.11.12

[release-branch.go1.11] go1.11.12

2019-07-08T19:49:55Z

Change-Id: I7d61b51d4b1b522315370bd17483feab24a2c7bb Reviewed-on: https://go-review.googlesource.com/c/go/+/185260 Reviewed-by: Dmitri Shuralyov Run-TryBot: Alexander Rakoczy TryBot-Result: Gobot Gobot

[release-branch.go1.11] doc: document Go 1.11.12

2019-07-08T18:37:13Z

Change-Id: I1b2e369befc58b3f88ac201442a2d9f76d87d54e Reviewed-on: https://go-review.googlesource.com/c/go/+/185257 Reviewed-by: Dmitri Shuralyov (cherry picked from commit 0fddd668671c44a622be7d7ea71962be644d8218) Reviewed-on: https://go-review.googlesource.com/c/go/+/185143

[release-branch.go1.11] cmd/compile: add necessary operand to mergePoint in rewrite rules

2019-07-08T17:48:29Z

A missing operand to mergePoint caused lower to place values in the wrong blocks. Includes test, belt+suspenders to do both ssa check and verify the output (was is how the bug was originally observed). The fixed bug here is very likely present in Go versions 1.9-1.12 on amd64 and s390x Updates #32680. Fixes #32711. Change-Id: I63e702c4c40602cb795ef71b1691eb704d38ccc7 Reviewed-on: https://go-review.googlesource.com/c/go/+/183059 Run-TryBot: David Chase TryBot-Result: Gobot Gobot Reviewed-by: Cherry Zhang (cherry picked from commit 769fda2d5110eef6146d7df3bf0219872c9b0da6) Reviewed-on: https://go-review.googlesource.com/c/go/+/183242

[release-branch.go1.11] cmd/link: revise previous __DWARF segment protection fix

2019-07-08T17:04:05Z

Tweak the previous fix for issue 32673 (in CL 182958) to work around problems with c-shared build mode that crop up on some of the builders (10.11, 10.12). We now consistently set vmaddr and vmsize to zero for the DWARF segment regardless of build mode. Fixes #32696. Change-Id: Id1fc213590ad00c28352925e2d754d760e022b5e Reviewed-on: https://go-review.googlesource.com/c/go/+/183237 Reviewed-by: Cherry Zhang Reviewed-by: David Chase Reviewed-on: https://go-review.googlesource.com/c/go/+/183400 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot

[release-branch.go1.11] cmd/link: macos: set initial protection of 0 for __DWARF segment

2019-07-08T17:03:39Z

For later versions of MacOS, the dynamic loader is more picky about enforcing restrictions on __DWARF MachO load commands/segments, triggering aborts of the form dyld: malformed mach-o image: segment __DWARF has vmsize < filesize for Go programs that use cgo on Darwin. The error is being triggered because the Go linker is setting "vmsize" in the DWARF segment entry to zero as a way to signal that the DWARF doesn't need to be mapped into memory at runtime (which we need to continue to do). This patch changes the initial protection on the __DWARF segment to zero, which dyld seems to be happy with (this is used for other similar non-loadable sections such as __LLVM). Updates #32696 Change-Id: I9a73449c6d26c172f3d70361719943af381f37e6 Reviewed-on: https://go-review.googlesource.com/c/go/+/182958 Run-TryBot: Than McIntosh TryBot-Result: Gobot Gobot Reviewed-by: Cherry Zhang Reviewed-on: https://go-review.googlesource.com/c/go/+/183399

[release-branch.go1.11] cmd/compile: fix range analysis of small signed integers

2019-07-01T17:22:40Z

For int8, int16, and int32, comparing their unsigned value to MaxInt64 to determine non-negativity doesn't make sense, because they have negative values whose unsigned representation is smaller than that. Fix is simply to compare with the appropriate upper bound based on the value type's size. Fixes #32582. Change-Id: Ie7afad7a56af92bd890ba5ff33c86d1df06cfd9a Reviewed-on: https://go-review.googlesource.com/c/go/+/181797 Run-TryBot: Matthew Dempsky Reviewed-by: Josh Bleecher Snyder Reviewed-by: David Chase Reviewed-by: Keith Randall TryBot-Result: Gobot Gobot (cherry picked from commit f44404ebbfeff57f3e45ebf4b314a320bb89841f) Reviewed-on: https://go-review.googlesource.com/c/go/+/181979 Reviewed-by: Russ Cox

[release-branch.go1.11] go1.11.11

2019-06-11T18:11:11Z

Change-Id: If078ff25a79a18429e3383207eae32bb9c8aec12 Reviewed-on: https://go-review.googlesource.com/c/go/+/181657 Reviewed-by: Katie Hockman Reviewed-by: Filippo Valsorda Run-TryBot: Dmitri Shuralyov TryBot-Result: Gobot Gobot

[release-branch.go1.11] doc: document Go 1.11.11

2019-06-11T00:27:41Z

Change-Id: I1c3e3305dfee4545a6caedd48243770ab3b28277 Reviewed-on: https://go-review.googlesource.com/c/go/+/181550 Reviewed-by: Filippo Valsorda (cherry picked from commit 55453016979124e18d3afb53c9df1590877a3b53) Reviewed-on: https://go-review.googlesource.com/c/go/+/181597

[release-branch.go1.11] crypto/x509: fix value ownership in isSSLPolicy on macOS

2019-06-07T20:50:08Z

CFDictionaryGetValueIfPresent does not take ownership of the value, so releasing the properties dictionary before passing the value to CFEqual can crash. Not really clear why this works most of the time. See https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html Fixes #32281 Updates #28092 Updates #30763 Change-Id: I5ee7ca276b753a48abc3aedfb78b8af68b448dd4 Reviewed-on: https://go-review.googlesource.com/c/go/+/178537 Reviewed-by: Adam Langley (cherry picked from commit a3d4655c2435e3777c45f09650539b943bab1c66) Reviewed-on: https://go-review.googlesource.com/c/go/+/179340 Run-TryBot: Dmitri Shuralyov TryBot-Result: Gobot Gobot Reviewed-by: Dmitri Shuralyov

[release-branch.go1.11] go1.11.10

2019-05-06T20:50:17Z

Change-Id: Id0cb0233c689fd97aa37870126d19b472bd1b85d Reviewed-on: https://go-review.googlesource.com/c/go/+/175445 Run-TryBot: Andrew Bonventre Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot