go, branch go1.10.5

[release-branch.go1.10] go1.10.5

2018-11-02T20:17:59Z

Change-Id: Ibad4471510ea8546954c4361424daadb845b2f3f Reviewed-on: https://go-review.googlesource.com/c/147183 Run-TryBot: Andrew Bonventre Reviewed-by: Brad Fitzpatrick

[release-branch.go1.10] doc: document Go 1.10.5

2018-11-02T19:53:46Z

Change-Id: I11adca150ab795607b832fb354a3e065655e1020 Reviewed-on: https://go-review.googlesource.com/c/147179 Reviewed-by: Brad Fitzpatrick (cherry picked from commit 2764d5ee7b23ae1caf2a4cd4506116a1b9efbf66) Reviewed-on: https://go-review.googlesource.com/c/147180 Reviewed-by: Andrew Bonventre

[release-branch.go1.10] cmd/internal/obj/arm64: fix branch-too-far with TBZ like instructions

2018-11-02T17:45:38Z

The compiler now emits TBZ like instructions, but the assembler's too-far-branch patch code didn't include that case. Add it. Updates #23889 Fixes #25794 Change-Id: Ib75f9250c660b9fb652835fbc83263a5d5073dc5 Reviewed-on: https://go-review.googlesource.com/94902 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot Reviewed-by: David Chase (cherry picked from commit 911839c1f462260db0f001f8e017f10f688d2270) Reviewed-on: https://go-review.googlesource.com/c/147057 Reviewed-by: Cherry Zhang Run-TryBot: Dmitri Shuralyov

[release-branch.go1.10] internal/poll: advance file position in windows sendfile

2018-11-01T22:47:33Z

Some versions of Windows (Windows 10 1803) do not set file position after TransmitFile completes. So just use Seek to set file position before returning from sendfile. Updates #25722 Fixes #27419 Change-Id: I7a49be10304b5db19dda707b13ac93d338aeb190 Reviewed-on: https://go-review.googlesource.com/131976 Reviewed-by: Brad Fitzpatrick Reviewed-by: Ian Lance Taylor Reviewed-by: Yasuhiro MATSUMOTO Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot (cherry picked from commit 8359b5e134052db0e5f1bc2257d496b0a81aa4fb) Reviewed-on: https://go-review.googlesource.com/c/146779 Run-TryBot: Ian Lance Taylor

[release-branch.go1.10] database/sql: check for nil connRequest.conn before use

2018-11-01T22:08:28Z

The connRequest may return a nil conn value. However in a rare case that is difficult to test for it was being passed to DB.putConn without a nil check. This was an error as this made no sense if the driverConn is nil. This also caused a panic in putConn. A test for this would be nice, but didn't find a sane way to test for this condition. Updates #24445 Fixes #25235 Change-Id: I827316e856788a5a3ced913f129bb5869b7bcf68 Reviewed-on: https://go-review.googlesource.com/102477 Run-TryBot: Daniel Theophanes TryBot-Result: Gobot Gobot Reviewed-by: Alexey Palazhchenko Reviewed-by: Brad Fitzpatrick (cherry picked from commit b98ffdf859f0fec2acb1765bf5b62ce1e4587c2b) Reviewed-on: https://go-review.googlesource.com/c/146778 Run-TryBot: Brad Fitzpatrick Reviewed-by: Katie Hockman

[release-branch.go1.10] internal/poll, net: fix sendfile on Windows, add test

2018-11-01T22:07:01Z

Cherry pick of CL 130855, done manually to avoid a merge conflict on the test. Fixes #27085 Change-Id: I7c4939cf5db23253a824c46c3f00fab4edec86b4 Reviewed-on: https://go-review.googlesource.com/c/146797 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick

[release-branch.go1.10] cmd/go: remove test that does nothing in 1.10

2018-11-01T21:47:17Z

1.10 has no cmd/go/testdata/script directory. Change-Id: I8985d457e8d6d0c8aeff9c17375f3c872593ab92 Reviewed-on: https://go-review.googlesource.com/c/146781 Run-TryBot: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot

[release-branch.go1.10] internal/poll: specify current file position when calling TransmitFile

2018-11-01T21:42:02Z

Current SendFile implementation assumes that TransmitFile starts from the current file position. But that appears not true for Windows 10 Version 1803. TransmitFile documentation https://msdn.microsoft.com/en-us/library/windows/desktop/ms740565(v=vs.85).aspx suggests, "You can use the lpOverlapped parameter to specify a 64-bit offset within the file at which to start the file data transfer by setting the Offset and OffsetHigh member of the OVERLAPPED structure." Do as it advises. Fixes #25722 Change-Id: I241d3bf76d0d5590d4df27c6f922d637068232fb Reviewed-on: https://go-review.googlesource.com/117816 Run-TryBot: Alex Brainman TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick (cherry picked from commit af4d60428f6dc5eab10b6de23235f61cceee8bc3) Reviewed-on: https://go-review.googlesource.com/c/146780 Run-TryBot: Ian Lance Taylor

[release-branch.go1.10] cmd/compile: prevent overflow in walkinrange

2018-11-01T20:08:12Z

In the compiler frontend, walkinrange indiscriminately calls Int64() on const CTINT nodes, even though Int64's return value is undefined for anything over 2⁶³ (in practise, it'll return a negative number). This causes the introduction of bad constants during rewrites of unsigned expressions, which make the compiler reject valid Go programs. This change introduces a preliminary check that Int64() is safe to call on the consts on hand. If it isn't, walkinrange exits without doing any rewrite. Fixes #27247 Change-Id: I2017073cae65468a521ff3262d4ea8ab0d7098d9 Reviewed-on: https://go-review.googlesource.com/130735 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Josh Bleecher Snyder (cherry picked from commit 42cc4ca30a7729a4c6d1bb0bbbc3e4a736ef91c8) Reviewed-on: https://go-review.googlesource.com/c/131595 Run-TryBot: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov

[release-branch.go1.10] cmd/go: add GOMIPS value to build id for mipsle

2018-11-01T19:27:43Z

Strip a trailing "le" from the GOARCH value when calculating the GOxxx environment variable that affects it. Updates #27260 Fixes #27421 Change-Id: I081f30d5dc19281901551823f4f56be028b5f71a Reviewed-on: https://go-review.googlesource.com/131379 Reviewed-by: Brad Fitzpatrick (cherry picked from commit 61318d7ffe8a49e9dedc5aa8195a164a3821465c) Reviewed-on: https://go-review.googlesource.com/c/146560 Run-TryBot: Dmitri Shuralyov TryBot-Result: Gobot Gobot