go, branch bench-before

bufio: realign struct Scanner

2024-01-24T21:01:14Z

This reduce the Scanner allocation size from 112 to 72 bytes.

bufio: realign struct Reader

2024-01-24T21:01:14Z

This reduce the Reader allocation size from 72 to 40 bytes and Writer allocation size from 64 to 40 bytes.

mime/quotedprintable: fix encoding where a period alone on a line

2024-01-24T21:01:14Z

Given the following example of message body, A line that precisely have length 75 with . + LF will cause DATA truncation.\n \n Footer.\n The quotedprintable Writer will encode the message into, A line ... truncation=\r\n .\r\n \r\n Footer.\r\n If we pass the Writer output into SMTP DATA command, the server read the "\r\n.\r\n" as the end of DATA which cause the message truncated on the receiver. This changes fix this issue by encode the period at the end with "=2E" based on recommendation in RFC 2049 Section 3, point (8) [1]. [1] https://www.rfc-editor.org/rfc/rfc2049.html#section-3 Fixes #61235 Change-Id: I350387b183ac6b25886f4084a060dcfcb48232a9

encoding/json: optimize isValidNumber function

2024-01-24T21:01:14Z

Instead of re-slicing the string for checking the value, use single index variable. Benchmark result, name old time/op new time/op delta NumberIsValid-8 19.0ns ± 0% 14.5ns ± 1% -23.70% (p=0.008 n=5+5) name old alloc/op new alloc/op delta NumberIsValid-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta NumberIsValid-8 0.00 0.00 ~ (all equal) Change-Id: I4698c5db134998f83ff47fb3add6a04ba6ec3aa0

testing: change the FAIL and SKIP prefix to "!!!" and "???"

2024-01-24T21:01:14Z

Previously, there are three output of message printed by test or benchmark: PASS, SKIP, or FAIL. All of them use the same prefix "---". In case we have a module that run many many tests, it's become hard to differentiate between PASS, SKIP, and FAIL. This changes differentiate the SKIP and FAIL using different prefix. For SKIP we prefix it with "???", for FAIL we prefix it with "!!!".

all: prealloc slice with possible minimum capabilities

2024-01-24T21:01:14Z

encoding/binary: add benchmark for writing slice of uint8

2024-01-24T21:01:14Z

all: add Makefile to rebuild go and other tools from source

2024-01-24T21:01:14Z

Revert "archive/tar: add FileInfoNames interface"

2024-01-24T20:54:27Z

This reverts CL 514235. Also reverts CL 518056 which is a followup fix. Reason for revert: Proposal #50102 defined an interface that is too specific to UNIX-y systems and also didn't make much sense. The proposal is un-accepted, and we'll revisit in Go 1.23. Fixes (via backport) #65245. Updates #50102. Change-Id: I41ba0ee286c1d893e6564a337e5d76418d19435d Reviewed-on: https://go-review.googlesource.com/c/go/+/558295 Reviewed-by: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov

net: ignore Dial errors in TestAcceptTimeout

2024-01-24T18:06:55Z

Also use DialContext instead of just Dial so that we can ensure the call returns before we close the listener. The Dial in this test is intended to complete before the call to Accept, but there is no synchronization to ensure that and sometimes it doesn't happen. That's ok and mostly immaterial to the test, but it does mean we need to ignore Dial errors (which can happen when the listener is closed), and we need to be a little more careful about not dialing a port that may have already been reused by some other test. Fixes #65240. Updates #17948. Change-Id: Ife1b5c3062939441b58f4c096461bf5d7841889b Reviewed-on: https://go-review.googlesource.com/c/go/+/558175 Reviewed-by: Damien Neil TryBot-Result: Gopher Robot Run-TryBot: Bryan Mills Auto-Submit: Bryan Mills LUCI-TryBot-Result: Go LUCI