go-x-review/git-codereview/api.go, branch main

git-codereview: support remote other than "origin"

2026-04-09T15:20:06Z

For the git-codereview commands to works on any Go's repositories, the remote name for "origin" must be pointed to the Go original repository URL (in most cases the one with go.googlesource.com domain). The problem is when the "origin" is from the fork, all of the git-codereview commands then will not works. For example, in computer X, I clone the this repository from "https://go.googlesource.com/review" (the origin) and then push my changes on "git@git.sr.ht:~shulhan/go-x-review" (the fork). In another computer Y, I then clone from the fork to continue my works. The fork become origin. One of the solution is to rename the remote names manually each time we clone the fork. The only cons using this solution is every time new branch created we need to remember to pass "--set-upstream" during git push. This changes introduce "remote" configuration in codereview.cfg. When one first working on fork of Go repository, they set the "remote" key, commit it, and push it. When they cloned the fork, they did not needs to changes anything except adding new remote using the pre-defined name. Change-Id: I335d08fd8b7efe17ba07b3c0a3794f9ccf59b339

git-codereview: fix some comments

2025-10-24T16:37:34Z

Change-Id: I0650c81a855138049e9132d56cc742620ecaf185 Reviewed-on: https://go-review.googlesource.com/c/review/+/713362 Reviewed-by: Sean Liao LUCI-TryBot-Result: Go LUCI Auto-Submit: Sean Liao Reviewed-by: David Chase Reviewed-by: Dmitri Shuralyov

git-codereview: remove usage of io/ioutil

2024-01-25T17:04:12Z

io/ioutil is now deprecated. Use non-deprecated equivalents. Change-Id: Iad1cc9c14dbdad3a6f9ada25072bc194bace4081 Reviewed-on: https://go-review.googlesource.com/c/review/+/543615 Reviewed-by: qiulaidongfeng <2645477756@qq.com> Auto-Submit: Dmitri Shuralyov Reviewed-by: Cherry Mui Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov

git-codereview: recognize sso://go/ and rpc://go/

2023-06-02T02:03:04Z

Google engineers are now required to use these access methods instead of https://go.googlesource.com/, so recognize them as aliases. (It is possible for every engineer to configure their Git clients with insteadOf clauses to hide these from the codereview plugin, but it's far less error-prone to just handle it here.) Change-Id: Ic1c9a6b45aa61b11ff25ce21bca6e49344974b04 Reviewed-on: https://go-review.googlesource.com/c/review/+/499923 TryBot-Result: Gopher Robot Reviewed-by: Peter Weinberger Run-TryBot: Russ Cox

git-codereview: allow trailing slash in git origin

2022-11-01T17:36:02Z

An origin like "https://go.googlesource.com/build/" should also work. Perhaps this should use net/url instead of parsing URLs by hand. Change-Id: I5304324ae67c054b8377d500ecafe46b296d1531 Reviewed-on: https://go-review.googlesource.com/c/review/+/442875 Reviewed-by: Heschi Kreinick Run-TryBot: Benny Siegert TryBot-Result: Gopher Robot

git-codereview: print more about Gerrit API errors

2022-06-01T20:01:15Z

For golang/go#50576. Change-Id: I3b67234098cbf9cd28bfa578c0b29744a4add2a3 Reviewed-on: https://go-review.googlesource.com/c/review/+/409914 Run-TryBot: Russ Cox Reviewed-by: Dmitri Shuralyov Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov

git-codereview: print about all Gerrit API errors

2022-04-14T15:34:40Z

Trying to chase down a problem with slow builders. If this gets to be too chatty, we can limit it to builders. For golang/go#50576. Change-Id: I16c7818153d2444c897b4946ce7baebbd646ab23 Reviewed-on: https://go-review.googlesource.com/c/review/+/399116 Run-TryBot: Russ Cox TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills

git-codereview: pending: show unresolved comment count

2021-02-23T10:45:24Z

Also fix a potential crash parsing a commit with no parents. Change-Id: I1c289dde45230a3362f54037ea18023278b05ffd Reviewed-on: https://go-review.googlesource.com/c/review/+/294129 Trust: Russ Cox Run-TryBot: Russ Cox TryBot-Result: Go Bot Reviewed-by: Ian Lance Taylor

git-codereview: avoid race in loadGerritOrigin

2021-01-27T23:04:16Z

Use a mutex in loadGerritOrigin to avoid race when called in parallel by "git coderevew pending". Add a new initialized field so that the code knows when auth has been initialized. Adjust tests accordingly. The test is simply "go test -race". Fixes golang/go#43670 Change-Id: Ifb060fca6ed463f1d11a2959d03fca5e14e238c6 Reviewed-on: https://go-review.googlesource.com/c/review/+/287012 Trust: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Go Bot Reviewed-by: Bryan C. Mills

git-codereview: remove use of Mergeable

2020-03-11T14:50:59Z

Mergeable has been removed from the Gerrit API - it was too expensive to maintain, had racy semantics, and was too little used. As of right now, git submit fails because it doesn't see "mergeable":true in the JSON. Remove the use of it in git-codereview. Change-Id: I12c821b9dbc44183a689d510dd20104eab5a0043 Reviewed-on: https://go-review.googlesource.com/c/review/+/222937 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Andrew Bonventre