go-x-review, branch v1.6.0

git-codereview: change default -trybot flag to use LUCI

2023-08-28T20:59:30Z

For when it's time. Change-Id: Ife6df8eed0a02d9a47ffca141be083aaf3b09d28 Reviewed-on: https://go-review.googlesource.com/c/review/+/523115 Auto-Submit: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov Reviewed-by: Heschi Kreinick LUCI-TryBot-Result: Go LUCI

git-codereview: add GIT_CODEREVIEW_TRYBOT env var to control CI system

2023-08-25T20:23:13Z

The mail command has a -trybot flag, useful to start TryBots on the CL being mailed. The new LUCI trybots are almost ready, and we'll soon be asking contributors to consider them the new default. Prepare for that by adding a temporary GIT_CODEREVIEW_TRYBOT environment variable which will make it possible to override the CI system invoked by the -trybot flag. This CL keeps the default as the old CI system (farmer.golang.org), and the next CL switches it to the new one (ci.chromium.org/p/golang). The environment variable will eventually be removed once it has no use. Change-Id: Ia20bb0cad1fee387b2d94a8438e8a3be3ec87e6b Reviewed-on: https://go-review.googlesource.com/c/review/+/523095 Reviewed-by: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov Auto-Submit: Dmitri Shuralyov LUCI-TryBot-Result: Go LUCI Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot

git-codereview: fix comment

2023-08-16T01:59:36Z

Change-Id: I265d394872a05441ccbf73388e9ff1b625435343 Reviewed-on: https://go-review.googlesource.com/c/review/+/518638 TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor

git-codereview: allow _content to not warn

2023-07-27T22:19:34Z

Fixes golang/go#45734 Change-Id: I20ebc9fb728c5e91a3d71d3a6290ccf27ceb14cf Reviewed-on: https://go-review.googlesource.com/c/review/+/496775 Run-TryBot: Dmitri Shuralyov TryBot-Result: Gopher Robot Auto-Submit: Dmitri Shuralyov Reviewed-by: Heschi Kreinick Reviewed-by: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov

git-codereview: fix TestReword on Windows

2023-06-26T16:37:10Z

It wasn't caught by x/build's Windows builders because they don't have git and skip these tests. But LUCI ones do have git, and caught this. For golang/go#46693. Change-Id: I50f3b69909344f4657e5c737e3b434a2538e4939 Reviewed-on: https://go-review.googlesource.com/c/review/+/505895 Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot Run-TryBot: Dmitri Shuralyov Auto-Submit: Dmitri Shuralyov Reviewed-by: Heschi Kreinick

git-codereview: fix mail lookup for dmitshur short name

2023-06-22T19:53:14Z

CL 2111 introduced a simple algorithm for expanding short user names that works locally and generally doesn't need any extra configuration to do the right thing. It's been serving for almost a decade. Unfortunately I'm running into an edge where I see no good option but to add a special case. Gerrit inserts "Reviewed-by" footers both for Code-Review +2 and +1 votes without any way to distinguish between them, and my @google.com account unavoidably gets more hits since I use it for the go.dev/s/needs-review process, whenever I leave a normal +2, and on my own CLs. The simplest fix seems to be to exclude it from short matches and let the existing algorithm do the rest. Change-Id: I92da69f1cd87b4c89816547015cffbed3eaaeaf6 Reviewed-on: https://go-review.googlesource.com/c/review/+/494175 Reviewed-by: MKaslann1 TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov Reviewed-by: Heschi Kreinick Run-TryBot: Dmitri Shuralyov Auto-Submit: Dmitri Shuralyov

git-codereview: recognize sso://go/ and rpc://go/

2023-06-02T02:03:04Z

Google engineers are now required to use these access methods instead of https://go.googlesource.com/, so recognize them as aliases. (It is possible for every engineer to configure their Git clients with insteadOf clauses to hide these from the codereview plugin, but it's far less error-prone to just handle it here.) Change-Id: Ic1c9a6b45aa61b11ff25ce21bca6e49344974b04 Reviewed-on: https://go-review.googlesource.com/c/review/+/499923 TryBot-Result: Gopher Robot Reviewed-by: Peter Weinberger Run-TryBot: Russ Cox

git-codereview: allow trailing slash in git origin

2022-11-01T17:36:02Z

An origin like "https://go.googlesource.com/build/" should also work. Perhaps this should use net/url instead of parsing URLs by hand. Change-Id: I5304324ae67c054b8377d500ecafe46b296d1531 Reviewed-on: https://go-review.googlesource.com/c/review/+/442875 Reviewed-by: Heschi Kreinick Run-TryBot: Benny Siegert TryBot-Result: Gopher Robot

git-codereview: add -autosubmit

2022-10-03T20:07:31Z

Add a flag to set the Auto-Submit label. For golang/go#48021. Change-Id: If704e8b5e9e0e2521eed78fe28af10d3c31ec3a0 Reviewed-on: https://go-review.googlesource.com/c/review/+/431375 Auto-Submit: Heschi Kreinick TryBot-Result: Gopher Robot Reviewed-by: Russ Cox Run-TryBot: Heschi Kreinick

A+C: delete AUTHORS and CONTRIBUTORS

2022-07-22T15:52:49Z

In 2009, Google's open-source lawyers asked us to create the AUTHORS file to define "The Go Authors", and the CONTRIBUTORS file was in keeping with open source best practices of the time. Re-reviewing our repos now in 2022, the open-source lawyers are comfortable with source control history taking the place of the AUTHORS file, and most open source projects no longer maintain CONTRIBUTORS files. To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos. For golang/go#53961. Change-Id: Idf51261da9667c3f04b13976ed0686f06cbf42c0 Reviewed-on: https://go-review.googlesource.com/c/review/+/419101 Run-TryBot: Russ Cox Reviewed-by: David Chase TryBot-Result: Gopher Robot