<feed xmlns='http://www.w3.org/2005/Atom'>
<title>go-x-pkgsite/internal/postgres/insert_module_test.go, branch main</title>
<subtitle>Fork of golang.org/x/pkgsite with my patches.</subtitle>
<id>http://git.kilabit.info/go-x-pkgsite/atom?h=main</id>
<link rel='self' href='http://git.kilabit.info/go-x-pkgsite/atom?h=main'/>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/'/>
<updated>2026-03-26T20:34:39Z</updated>
<entry>
<title>all: fix rangeint</title>
<updated>2026-03-26T20:34:39Z</updated>
<author>
<name>Hana Kim</name>
<email>hyangah@gmail.com</email>
</author>
<published>2026-03-06T03:46:58Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=8378ff811c1228f6a50808cb7557e6c08782205a'/>
<id>urn:sha1:8378ff811c1228f6a50808cb7557e6c08782205a</id>
<content type='text'>
Change-Id: I58ed5e7d2a3bbc13bc389ac7239737e18856dbfe
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753427
Reviewed-by: Jonathan Amsterdam &lt;jba@google.com&gt;
Reviewed-by: Ethan Lee &lt;ethanalee@google.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
LUCI-TryBot-Result: Go LUCI &lt;golang-scoped@luci-project-accounts.iam.gserviceaccount.com&gt;
</content>
</entry>
<entry>
<title>all: add LatestVersion to ModuleInfo</title>
<updated>2026-03-25T15:29:54Z</updated>
<author>
<name>Ethan Lee</name>
<email>ethanalee@google.com</email>
</author>
<published>2026-03-18T20:31:16Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=c57126f9757fb25c781a59cb9ecc97b0af63727a'/>
<id>urn:sha1:c57126f9757fb25c781a59cb9ecc97b0af63727a</id>
<content type='text'>
- Add LatestVersion field to internal.ModuleInfo and update tests
  accordingly.
- Changed some test formatting to improve readability.

Change-Id: I1238e54614ef276d219b31d125cd2cad6b5a66f7
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/756901
LUCI-TryBot-Result: Go LUCI &lt;golang-scoped@luci-project-accounts.iam.gserviceaccount.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
Auto-Submit: Ethan Lee &lt;ethanalee@google.com&gt;
Reviewed-by: Jonathan Amsterdam &lt;jba@google.com&gt;
</content>
</entry>
<entry>
<title>Revert "internal/postgres: utilize num_imports column in insert_module"</title>
<updated>2025-11-17T19:07:52Z</updated>
<author>
<name>Ethan Lee</name>
<email>ethanalee@google.com</email>
</author>
<published>2025-11-17T18:26:27Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=eaf237733d265b7045c7c51bd4b3989afeb56e4b'/>
<id>urn:sha1:eaf237733d265b7045c7c51bd4b3989afeb56e4b</id>
<content type='text'>
This reverts commit 28eed86815232e48f5e757569fcd061f858142d4.

Reason for revert: migration takes too long

Change-Id: I279e62342c79d2604cda4e7c9819bdaa8aac752c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/721101
LUCI-TryBot-Result: Go LUCI &lt;golang-scoped@luci-project-accounts.iam.gserviceaccount.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Robert Findley &lt;rfindley@google.com&gt;
</content>
</entry>
<entry>
<title>internal/postgres: utilize num_imports column in insert_module</title>
<updated>2025-11-13T21:36:12Z</updated>
<author>
<name>Ethan Lee</name>
<email>ethanalee@google.com</email>
</author>
<published>2025-11-13T19:51:08Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=28eed86815232e48f5e757569fcd061f858142d4'/>
<id>urn:sha1:28eed86815232e48f5e757569fcd061f858142d4</id>
<content type='text'>
- Avoid recomputing number of imports for every query in getUnitWithAllFields.

For golang/go#76284

Change-Id: I7f7d683efb1b2ff49e33681802896a65b1354d25
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/720261
LUCI-TryBot-Result: Go LUCI &lt;golang-scoped@luci-project-accounts.iam.gserviceaccount.com&gt;
Reviewed-by: Robert Findley &lt;rfindley@google.com&gt;
Auto-Submit: Ethan Lee &lt;ethanalee@google.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
</content>
</entry>
<entry>
<title>internal/postgres: add skip-symbols list to saveModule</title>
<updated>2025-10-23T14:28:57Z</updated>
<author>
<name>Ethan Lee</name>
<email>ethanalee@google.com</email>
</author>
<published>2025-10-20T08:30:00Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=fe04cb7342faa5af6b014191b12b56d823382fc7'/>
<id>urn:sha1:fe04cb7342faa5af6b014191b12b56d823382fc7</id>
<content type='text'>
- Modules in the skip-symbols list will not have symbol information inserted into postgres.

Change-Id: Ia52b9eb2d7cab662b967fa4a74c40cced0e44be4
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/713060
Reviewed-by: Jonathan Amsterdam &lt;jba@google.com&gt;
Reviewed-by: Peter Weinberger &lt;pjw@google.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
LUCI-TryBot-Result: Go LUCI &lt;golang-scoped@luci-project-accounts.iam.gserviceaccount.com&gt;
</content>
</entry>
<entry>
<title>internal/postgres: insert module path even if not a package</title>
<updated>2024-09-04T17:48:17Z</updated>
<author>
<name>Jonathan Amsterdam</name>
<email>jba@google.com</email>
</author>
<published>2024-08-30T15:25:35Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=1551f083f9733f4544cf19c0900662e07271ed5e'/>
<id>urn:sha1:1551f083f9733f4544cf19c0900662e07271ed5e</id>
<content type='text'>
When inserting the paths of a module into the paths table, we were
inserting all the package paths and the v1 module path (the module path
without "/vN" suffix). That is almost always sufficient. But if a module
has a version suffix and is not itself a package, then we were not
inserting its path. The module path is needed by insertSymbols, so this
was causing that function to fail.

Add the module path, refactor the code to simplify it and allow testing,
and add a test.

(For a vN module the code also adds the v1 package path for every
package. I think this is unnecessary, but it's too risky to remove
it.)

Change-Id: I8caa3dd945692a4ec0a1128199237de6b77aa719
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/609117
LUCI-TryBot-Result: Go LUCI &lt;golang-scoped@luci-project-accounts.iam.gserviceaccount.com&gt;
Reviewed-by: Robert Findley &lt;rfindley@google.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
</content>
</entry>
<entry>
<title>all: remove arbitrary hard-coded timeouts in tests</title>
<updated>2023-08-23T16:58:07Z</updated>
<author>
<name>Bryan C. Mills</name>
<email>bcmills@google.com</email>
</author>
<published>2023-08-22T19:23:22Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=76f4137fe5bb3d97d1ffa28cb490e71a96d5dcb9'/>
<id>urn:sha1:76f4137fe5bb3d97d1ffa28cb490e71a96d5dcb9</id>
<content type='text'>
If a test times out, that implies that it got stuck on something.
By default, the Go testing package dumps goroutines when its own
timeout is passed, which prints a goroutine dump, helping to reveal
what was stuck.

Adding an arbitrary timeout on top of the testing package's own
timeout is, in my experience, almost always counterproductive.
If the arbitrary timeout catches a real hang, it causes the test to
fail instead of dumping goroutines, making it much harder to see what
was stuck. On the other hand, if the timeouts are set aggressively
enough to make the test fail early, they are often too aggressive
for CI testing, causing flakes that then have to be triaged on an
ongoing basis.

On balance, the value of saving a minute or two for developers who
have introduced a hang is not worth the cost of suppressing debugging
information and causing flakes that have to be triaged.

Fixes #61556.
For #59347.

Change-Id: I0263d0d9b18283470f100e5a0155818b87b5312f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521837
TryBot-Result: Gopher Robot &lt;gobot@golang.org&gt;
Auto-Submit: Bryan Mills &lt;bcmills@google.com&gt;
Run-TryBot: Bryan Mills &lt;bcmills@google.com&gt;
kokoro-CI: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Michael Matloob &lt;matloob@golang.org&gt;
</content>
</entry>
<entry>
<title>many: re-enable staticcheck and fix problems</title>
<updated>2022-06-17T13:49:06Z</updated>
<author>
<name>Jonathan Amsterdam</name>
<email>jba@google.com</email>
</author>
<published>2022-06-16T14:02:13Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=24f94ffc546bde6aae0552efa6a940041d9d28e1'/>
<id>urn:sha1:24f94ffc546bde6aae0552efa6a940041d9d28e1</id>
<content type='text'>
Most of the checks were about io/ioutil. There were a couple of
other minor ones. I didn't address the check for strings.Title;
instead, I turned off that check globally with a staticcheck.conf
file.

Change-Id: I286a6894fb1fd891818ab9e451c891f52a3828fc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/412675
Reviewed-by: Jamal Carvalho &lt;jamal@golang.org&gt;
Run-TryBot: Jonathan Amsterdam &lt;jba@google.com&gt;
TryBot-Result: kokoro &lt;noreply+kokoro@google.com&gt;
</content>
</entry>
<entry>
<title>internal/database: use generics for Collect functions</title>
<updated>2022-03-07T15:51:22Z</updated>
<author>
<name>Jonathan Amsterdam</name>
<email>jba@google.com</email>
</author>
<published>2022-03-04T18:48:07Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=2beb68e7d8664b09d87cabe67943dc13b1131207'/>
<id>urn:sha1:2beb68e7d8664b09d87cabe67943dc13b1131207</id>
<content type='text'>
Reimplement some reflection-based collection functions to
use generics.

In some cases we still need reflection, but at least we
can provide a type-safe wrapper with generics.

Change-Id: Id95949a7a22ee687166ecdfc1191150d79568889
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/389657
Trust: Jonathan Amsterdam &lt;jba@google.com&gt;
Run-TryBot: Jonathan Amsterdam &lt;jba@google.com&gt;
TryBot-Result: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Jamal Carvalho &lt;jamal@golang.org&gt;
</content>
</entry>
<entry>
<title>internal/licenses: remove Metadata.OldCoverage</title>
<updated>2021-11-15T20:17:11Z</updated>
<author>
<name>Jonathan Amsterdam</name>
<email>jba@google.com</email>
</author>
<published>2021-11-15T14:18:34Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go-x-pkgsite/commit/?id=664ef416968ca8bc699cf240615bbce4bd366f49'/>
<id>urn:sha1:664ef416968ca8bc699cf240615bbce4bd366f49</id>
<content type='text'>
We don't need the OldCoverage field anymore. All DBs have
only the new Coverage information.

Change-Id: Ib2d8e0cdacdc2f7b6514a8a5310d6905be15136c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/363954
Trust: Jonathan Amsterdam &lt;jba@google.com&gt;
Run-TryBot: Jonathan Amsterdam &lt;jba@google.com&gt;
TryBot-Result: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Jamal Carvalho &lt;jamal@golang.org&gt;
</content>
</entry>
</feed>
