go-x-pkgsite/internal/database/database_test.go, branch main

all: fix rangeint

2026-03-26T20:34:39Z

Change-Id: I58ed5e7d2a3bbc13bc389ac7239737e18856dbfe Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753427 Reviewed-by: Jonathan Amsterdam Reviewed-by: Ethan Lee kokoro-CI: kokoro LUCI-TryBot-Result: Go LUCI

all: pgx/v4 to v5 and upgrade pq

2026-03-24T19:07:17Z

- In preparation for upgrade to PostgreSQL 17, upgrade stale dependencies within pkgsite. Change-Id: Id54cbb46182711b9808ee3bbbe2f0d5d9a04583d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/758121 Auto-Submit: Ethan Lee LUCI-TryBot-Result: Go LUCI Reviewed-by: Jonathan Amsterdam kokoro-CI: kokoro

internal/database: remove sawRetries logic from TestTransactSerializable

2026-03-05T17:51:55Z

- This test has a history of flakiness. PostgreSQL 14 includes significant improvements to its Serializable Snapshot Isolation which means it is much efficient in reducing false positive serialization conflicts. To amend this, this test now focuses on data integrity rather than an arbitary retry counter. Change-Id: I7d9a46303a6cc4eb011d9d3764ebf0c61e2d6287 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/751680 Reviewed-by: Hyang-Ah Hana Kim kokoro-CI: kokoro LUCI-TryBot-Result: Go LUCI Auto-Submit: Ethan Lee

all: remove arbitrary hard-coded timeouts in tests

2023-08-23T16:58:07Z

If a test times out, that implies that it got stuck on something. By default, the Go testing package dumps goroutines when its own timeout is passed, which prints a goroutine dump, helping to reveal what was stuck. Adding an arbitrary timeout on top of the testing package's own timeout is, in my experience, almost always counterproductive. If the arbitrary timeout catches a real hang, it causes the test to fail instead of dumping goroutines, making it much harder to see what was stuck. On the other hand, if the timeouts are set aggressively enough to make the test fail early, they are often too aggressive for CI testing, causing flakes that then have to be triaged on an ongoing basis. On balance, the value of saving a minute or two for developers who have introduced a hang is not worth the cost of suppressing debugging information and causing flakes that have to be triaged. Fixes #61556. For #59347. Change-Id: I0263d0d9b18283470f100e5a0155818b87b5312f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521837 TryBot-Result: Gopher Robot Auto-Submit: Bryan Mills Run-TryBot: Bryan Mills kokoro-CI: kokoro Reviewed-by: Michael Matloob

all: convert interface{} to any

2022-11-15T20:10:34Z

Change-Id: I1f3b7cc8899c7707abb01e3d14807c37c3451382 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/449695 TryBot-Result: kokoro Reviewed-by: Jamal Carvalho Run-TryBot: Hyang-Ah Hana Kim

internal: remove experiments

2022-04-21T15:17:02Z

Remove the deprecated-doc and deps-dev-link experiments, which have been fully rolled out. I found I also had to increase some parameters on the serializablity test in internal/database to make it pass on my machine. Reasons unknown. Change-Id: Ibcb1f8167474884d6c029da55f2d31b3c5adcfc6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/401237 Run-TryBot: Jonathan Amsterdam Reviewed-by: Jamal Carvalho

internal/database: use generics for Collect functions

2022-03-07T15:51:22Z

Reimplement some reflection-based collection functions to use generics. In some cases we still need reflection, but at least we can provide a type-safe wrapper with generics. Change-Id: Id95949a7a22ee687166ecdfc1191150d79568889 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/389657 Trust: Jonathan Amsterdam Run-TryBot: Jonathan Amsterdam TryBot-Result: kokoro Reviewed-by: Jamal Carvalho

internal/{database,postgres}: export CollectStrings

2021-07-21T13:37:24Z

Export the CollectStrings function and move to the database package so it can be used elsewhere. Change-Id: I1032e4f5042209e42e8f0de9cebfb48653d56f69 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/336209 Trust: Jonathan Amsterdam Run-TryBot: Jonathan Amsterdam TryBot-Result: kokoro Reviewed-by: Julie Qiu

internal/database: merge dbtest into package

2021-07-16T19:00:08Z

There doesn't seem to be any reason that dbtest needs to be its own package, and the functions there are useful for scripts beyond use in Go test files. db_test.go is merged into the internal/datbase package and the file is renamed to dbutil.go. References are fixed. Change-Id: I5ed295f147c5b9e891c243e2c5028708b12f5c75 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/335089 Trust: Julie Qiu Run-TryBot: Julie Qiu TryBot-Result: kokoro Reviewed-by: Jamal Carvalho Reviewed-by: Jonathan Amsterdam

internal/database: add ability to run queries incrementally

2021-06-18T17:41:02Z

Postgres lets you define a cursor and fetch rows from it as top-level statements, without needing to write any PS-SQL. See https://www.postgresql.org/docs/11/sql-declare.html and https://www.postgresql.org/docs/11/sql-fetch.html for details. Use this feature to define RunQueryIncrementally, which repeatedly fetches query rows in batches until it runs out or the passed function says it's done. If grouping by module paths is enabled, use RunQueryIncrementally with a very large limit to read rows until we've seen a page's worth of module paths. This CL doesn't handle pagination correctly. Any page after the first is going to be wrong. Change-Id: Idf8233160b0cf74412a688e1a6b95f4f2b720008 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/329469 Trust: Jonathan Amsterdam Run-TryBot: Jonathan Amsterdam TryBot-Result: kokoro Reviewed-by: Julie Qiu