go-x-pkgsite/internal/api/api.go, branch main

internal/api: improve ambiguous package path resolution

2026-04-13T18:42:30Z

Instead of falling back to UnknownModulePath, we now: 1. Query all candidate module paths. 2. Filter out candidates where the database fell back to a different module path (preventing false positives like google.golang.org). 3. Filter out deprecated or retracted candidates if at least one good candidate exists. 4. Return 400 if ambiguity remains among good candidates. This commit fixes the issue where /v1/package/google.golang.org/adk/agent was returning HTTP 400 because all candidate module paths matched: ``` { "code":400, "message":"ambiguous package path", "candidates":[ {"modulePath":"google.golang.org/adk/agent","packagePath":"google.golang.org/adk/agent"}, {"modulePath":"google.golang.org/adk","packagePath":"google.golang.org/adk/agent"}, {"modulePath":"google.golang.org","packagePath":"google.golang.org/adk/agent"}] } ``` Change-Id: I3ea24bca5144d536490019efd85fb597da214029 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/766380 kokoro-CI: kokoro Reviewed-by: Jonathan Amsterdam LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com

internal/api: refactor error handling to increase consistency

2026-04-09T20:23:05Z

- Refactored error handling to avoid leaking internal implementation details. Database and system errors are masked by falling back to standard HTTP statuses but still logging the entire error context. - User facing error messages can now be specified within the Error struct. - Added helpers in types.go to simplify error construction. - Updated ServeModuleVersions to explicitly return 404 when no versions are found. - Expanded test coverage in api_test.go to include 404 and 400 edge cases. Change-Id: I89c4be3941126c15df6aefdd21e4bbd2d3b23be1 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/764820 LUCI-TryBot-Result: Go LUCI Auto-Submit: Ethan Lee kokoro-CI: kokoro Reviewed-by: Jonathan Amsterdam

internal/api: simplify filter code

2026-04-09T18:29:52Z

Change-Id: I5510faeb196af4ce1418affe6159b17187b9efa5 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/764700 LUCI-TryBot-Result: Go LUCI Reviewed-by: Ethan Lee kokoro-CI: kokoro

internal/api: set cache-control headers

2026-04-08T20:35:34Z

Set an HTTP Cache-Control header for all API responses. Since requests that reference a specific, numbered version apparently always produce the same response, it is tempting to use the "immutable" Cache-Control directive so these pages can be cached indefinitely. But occasionally we must exclude a module. It would be unfortunate if the module's data lived in caches forever. Instead, we cache such pages for one day. Pages that are subject to more rapid change, like those with versions "latest", "master" and so on, or those that depend on data other than a module (imported-by, search, etc.) are cached for an hour. That is an arbitrary value that seems like a good compromise, since the likelihood of a particular page's value changing in an hour is low. Change-Id: I21414c22c724220c993c1dd7e7a0b49074efd8b9 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/763782 LUCI-TryBot-Result: Go LUCI Reviewed-by: Ethan Lee Reviewed-by: Hyang-Ah Hana Kim TryBot-Bypass: Jonathan Amsterdam

internal/api: add examples parameter to PackageParams

2026-04-08T18:49:01Z

- Enable conditional population of examples by introducing a new examples parameter. Change-Id: I53314344a414c41b423185c115e600ec8b63e6bf Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/763282 LUCI-TryBot-Result: Go LUCI Auto-Submit: Ethan Lee Reviewed-by: Jonathan Amsterdam kokoro-CI: kokoro

internal/api: clean up redundant TODO

2026-04-07T16:23:25Z

- The relevant logic has already been implemented. Change-Id: I1d4f92e6d6c00666ba09a532e378fc1f0ede7856 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/763400 LUCI-TryBot-Result: Go LUCI Auto-Submit: Ethan Lee kokoro-CI: kokoro Reviewed-by: Jonathan Amsterdam

internal/api: add support for readme and licenses in ServeModule

2026-04-07T16:23:15Z

- Utilize conditional fieldset in GetUnit to efficiently retrieve readme and license fields. - Modify Module type to include HasGoMod. Change-Id: Id22ac3f2485392749742332701d2e913f047b3da Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/763401 kokoro-CI: kokoro Auto-Submit: Ethan Lee LUCI-TryBot-Result: Go LUCI Reviewed-by: Jonathan Amsterdam

internal/api: unify default pagination limits

2026-04-07T15:31:17Z

Change-Id: Ie8faec1c02d74ac2559e78d8793d6050a98b38fc Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/763281 Auto-Submit: Ethan Lee LUCI-TryBot-Result: Go LUCI Reviewed-by: Jonathan Amsterdam kokoro-CI: kokoro

internal/api: refactor ServePackage and extract helper functions

2026-04-07T15:31:11Z

Change-Id: Iae93d49fdb6d3a196281d49cd2cf01a8b4e537e2 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/763280 kokoro-CI: kokoro LUCI-TryBot-Result: Go LUCI Auto-Submit: Ethan Lee Reviewed-by: Jonathan Amsterdam

internal/api: factor out common renderer things

2026-04-06T14:29:56Z

Change-Id: I5d8a579913942bcdea664af675ff2ef29888281c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/761400 TryBot-Bypass: Jonathan Amsterdam LUCI-TryBot-Result: Go LUCI Reviewed-by: Hyang-Ah Hana Kim Reviewed-by: Ethan Lee