go-x-crypto, branch v0.5.0

go.mod: update golang.org/x dependencies

2023-01-04T16:09:43Z

Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: I25128883772569c8f729b091b0efcbc4afcbea67 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/460500 Run-TryBot: Gopher Robot Auto-Submit: Gopher Robot TryBot-Result: Gopher Robot Reviewed-by: Dmitri Shuralyov Reviewed-by: Heschi Kreinick

bcrypt: reject passwords longer than 72 bytes

2022-12-21T17:19:30Z

By design, bcrypt only uses the first 72 bytes of a password when generating a hash. Most implementations, including the reference one, simply silently ignore any trailing input when provided passwords longer than 72 bytes. This can cause confusion for users who expect the entire password to be used to generate the hash. In GenerateFromPassword, reject passwords longer than 72 bytes. CompareHashAndPassword will still accept these passwords, since we cannot break hashes that have already been stored. Fixes golang/go#36546 Change-Id: I039addd2a2961a7fa9d1e4a3e892a9e3c8bf4c9a Reviewed-on: https://go-review.googlesource.com/c/crypto/+/450415 Reviewed-by: Damien Neil Reviewed-by: Jason McNeil TryBot-Result: Gopher Robot Reviewed-by: Filippo Valsorda Auto-Submit: Roland Shoemaker Run-TryBot: Roland Shoemaker

internal/wycheproof: also use Verify in TestECDSA

2022-12-21T16:58:14Z

Check both Verify and VerifyASN1 in the ECDSA tests. Change-Id: Id767354484a7da18ae4e00cd6f2a01a2909e6732 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/453755 Reviewed-by: Than McIntosh Run-TryBot: Roland Shoemaker TryBot-Result: Gopher Robot Reviewed-by: Filippo Valsorda

ssh: ensure that handshakeTransport goroutines have finished before Close returns

2022-12-12T22:32:12Z

This fixes a data race in the tests for x/crypto/ssh, which expects to be able to examine a transport's read and write counters without locking after closing it. (Given the number of goroutines, channels, and mutexes used in this package, I wouldn't be surprised if other concurrency bugs remain. I would suggest simplifying the concurrency in this package, but I don't intend to follow up on that myself at the moment.) Fixes golang/go#56957. Change-Id: Ib1f1390b66707c66a3608e48f3f52483cff3c1f5 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/456758 Reviewed-by: Roland Shoemaker TryBot-Result: Gopher Robot Auto-Submit: Bryan Mills Run-TryBot: Bryan Mills

acme: eliminate arbitrary timeouts in tests

2022-12-08T18:21:33Z

Fixes golang/go#57107. Change-Id: I20b1f6ca85170c6b4731d7c7ea06f4db742526cc Reviewed-on: https://go-review.googlesource.com/c/crypto/+/456123 TryBot-Result: Gopher Robot Run-TryBot: Bryan Mills Reviewed-by: Roland Shoemaker Auto-Submit: Bryan Mills

go.mod: update golang.org/x dependencies

2022-12-06T15:29:57Z

Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: If72a913d54ec282d75e270409971b148df4b417c Reviewed-on: https://go-review.googlesource.com/c/crypto/+/455436 Reviewed-by: Carlos Amedee Run-TryBot: Gopher Robot Auto-Submit: Gopher Robot Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot

cryptobyte: add support for ReadASN1Integer into []byte

2022-11-17T19:18:49Z

This lets us extract large integers without involving math/big. While at it, drop some use of reflect where a type switch will do. Change-Id: Iebe2fb2267610bf95cf9747ba1d49b5ac9e62cda Reviewed-on: https://go-review.googlesource.com/c/crypto/+/451515 Run-TryBot: Filippo Valsorda Reviewed-by: Damien Neil Reviewed-by: Bryan Mills Reviewed-by: Roland Shoemaker TryBot-Result: Gopher Robot Auto-Submit: Filippo Valsorda

internal/wycheproof: update Go 1.20 crypto/ecdh API

2022-11-16T16:25:40Z

For golang/go#56052 Change-Id: If34d01132e221ff525319e43d127ef14579f9054 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/451095 Reviewed-by: Bryan Mills Reviewed-by: Joedian Reid Auto-Submit: Filippo Valsorda Run-TryBot: Filippo Valsorda Run-TryBot: Joedian Reid TryBot-Result: Gopher Robot

ssh: support rsa-sha2-256/512 on the server side

2022-11-12T16:25:23Z

This lets clients know we support rsa-sha2-256/512 signatures from ssh-rsa public keys. OpenSSH prefers to break the connection rather than attempting trial and error, apparently. We don't enable support for the "ext-info-s" because we're not interested in any client->server extensions. This also replaces isAcceptableAlgo which was rejecting the rsa-sha2-256/512-cert-v01@openssh.com public key algorithms. Tested with OpenSSH 9.1 on macOS Ventura. Fixes golang/go#49269 Updates golang/go#49952 Co-authored-by: Nicola Murino Co-authored-by: Kristin Davidson Change-Id: I4955c3b12bb45575e9977ac657bb5805b49d00c3 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/447757 Run-TryBot: Filippo Valsorda TryBot-Result: Gopher Robot Reviewed-by: Roland Shoemaker Reviewed-by: Nicola Murino Reviewed-by: Michael Knyszek

all: remove redundant type conversion

2022-11-09T16:50:04Z

Change-Id: Ic6b210c1e5b99eef5c6e38d96feaf40e7e6033bb GitHub-Last-Rev: b8ecf761efe6a2eec78a805a99d778bdcdb938f9 GitHub-Pull-Request: golang/crypto#229 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/429016 Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot Reviewed-by: Michael Knyszek