go-x-crypto, branch v0.20.0

all: update go.mod x/net dependency

2024-02-26T19:05:04Z

Not necessary for anything, but need to test something harmless. Change-Id: I4faa64ef2c8f1f14df5ccaa37836fc56beed4f50 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/566917 LUCI-TryBot-Result: Go LUCI Auto-Submit: Gopher Robot Reviewed-by: Dmitri Shuralyov Reviewed-by: Roland Shoemaker Reviewed-by: Dmitri Shuralyov

ocsp: don't use iota for externally defined constants

2024-02-18T02:21:00Z

Style fix: iota shouldn't be used for values that come from RFCs or things that go over the wire or to disk. Change-Id: Ib903ec1bce7e71ff81094db3de8d0b71e16f52f3 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/564695 Reviewed-by: Dmitri Shuralyov Auto-Submit: Roland Shoemaker LUCI-TryBot-Result: Go LUCI Reviewed-by: Roland Shoemaker

x/crypto/internal/poly1305: improve sum_ppc64le.s

2024-02-15T13:30:21Z

This contains a few minor improvements to sum_ppc64le.s which result in up to 10% performance improvement for some of the benchmarks in this directory. - ADDZE followed by ADD can be combined into ADDE - PCALIGN added to the loop - Eliminate a few unnecessary register moves goos: linux goarch: ppc64le pkg: golang.org/x/crypto/internal/poly1305 cpu: POWER10 │ poly.orig.out │ poly.out │ │ sec/op │ sec/op vs base │ 64 40.34n ± 0% 38.13n ± 0% -5.47% (p=0.002 n=6) 1K 482.2n ± 0% 444.6n ± 0% -7.81% (p=0.002 n=6) 2M 978.4µ ± 0% 879.3µ ± 0% -10.12% (p=0.002 n=6) 64Unaligned 40.35n ± 0% 38.16n ± 0% -5.42% (p=0.002 n=6) 1KUnaligned 482.0n ± 0% 444.2n ± 0% -7.84% (p=0.002 n=6) 2MUnaligned 978.4µ ± 0% 879.4µ ± 0% -10.12% (p=0.002 n=6) Write64 32.69n ± 0% 30.71n ± 0% -6.04% (p=0.002 n=6) Write1K 472.4n ± 0% 436.5n ± 0% -7.60% (p=0.002 n=6) Write2M 978.3µ ± 0% 879.4µ ± 0% -10.11% (p=0.002 n=6) Write64Unaligned 32.67n ± 0% 30.71n ± 0% -6.00% (p=0.002 n=6) Write1KUnaligned 472.6n ± 0% 436.4n ± 0% -7.66% (p=0.002 n=6) Write2MUnaligned 978.5µ ± 0% 879.6µ ± 0% -10.10% (p=0.002 n=6) geomean 2.569µ 2.367µ -7.87% Change-Id: I63314e7252ef10fb2d157f623c4bc2e31a63ae32 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/558775 Reviewed-by: David Chase Reviewed-by: Michael Knyszek LUCI-TryBot-Result: Go LUCI Reviewed-by: Paul Murphy Run-TryBot: Lynn Boger TryBot-Result: Gopher Robot Reviewed-by: Than McIntosh

ssh/test: don't use DSA keys in integrations tests, update test RSA key

2024-02-14T13:16:51Z

on RHEL 9 OpenSSH does not support DSA keys and RSA keys with size less than 2048 bits, furthermore signing with ssh-rsa (SHA-1 signatures) and ssh-dss is not allowed, therefore: 1) replaced the 1024-bit RSA key used in the test with a new 2048-bit one 2) removed DSA key from itegration tests 3) allowed signature errors using ssh-rsa in agent integration tests, we also check SHA-2 variants that are not skipped Fixes golang/go#65581 Change-Id: I54bf997b61ef4d91d38eb624275737ba7291bb20 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/562755 Reviewed-by: Roland Shoemaker Reviewed-by: David Chase Reviewed-by: Filippo Valsorda Auto-Submit: Nicola Murino LUCI-TryBot-Result: Go LUCI

x509roots/nss: manually exclude a confusingly constrained root

2024-02-08T16:32:26Z

Fixes golang/go#61963 Change-Id: I16920d160af74772ef5aa650d1274e07c3ca9adc Reviewed-on: https://go-review.googlesource.com/c/crypto/+/562475 Reviewed-by: Filippo Valsorda LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov

go.mod: update golang.org/x dependencies

2024-02-07T19:12:06Z

Update golang.org/x dependencies to their latest tagged versions. Change-Id: I87d766a485104662172bf983d2a9deb085eddd99 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/562417 Reviewed-by: Than McIntosh Reviewed-by: Dmitri Shuralyov Auto-Submit: Gopher Robot LUCI-TryBot-Result: Go LUCI Reviewed-by: David Chase

x509roots/fallback: update bundle

2024-02-07T17:47:05Z

This is an automated CL which updates the NSS root bundle. Change-Id: I6d9163026799e5d134f6bb6819e22448d7ebe719 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/561395 Reviewed-by: Roland Shoemaker Auto-Submit: Gopher Robot LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov

ssh/test: skip tests on darwin that fail on the darwin-amd64-longtest LUCI builder

2024-01-08T16:44:29Z

We don't yet understand why these tests fail, but the Apple sshd seems to have some non-trivial vendor patches, so it is plausibly a platform-specific bug in the test. Let's skip that failure mode on the whole platform until/unless someone has time to reproduce and investigate the failure. For golang/go#64959. Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-darwin-amd64-longtest,x_crypto-gotip-linux-amd64-longtest,x_crypto-gotip-windows-amd64-longtest Change-Id: I9e43579469de3fe9329c093b5916bbed0edd3751 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/554077 Reviewed-by: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov Reviewed-by: Nicola Murino LUCI-TryBot-Result: Go LUCI Auto-Submit: Bryan Mills

ssh/test: avoid leaking a net.UnixConn in server.TryDialWithAddr

2024-01-08T16:33:12Z

For golang/go#64959. Change-Id: I2153166f4960058cdc2b82ae34ca250dcc6ba1c6 Cq-Include-Trybots: luci.golang.try:x_crypto-gotip-linux-amd64-longtest,x_crypto-gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/crypto/+/554062 Run-TryBot: Bryan Mills Auto-Submit: Bryan Mills Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov

go.mod: update golang.org/x dependencies

2024-01-04T15:35:59Z

Update golang.org/x dependencies to their latest tagged versions. Change-Id: I2df91d0602cd1ef94370de4a60a935edeb441333 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/553996 Reviewed-by: Than McIntosh LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov Auto-Submit: Gopher Robot Reviewed-by: Dmitri Shuralyov