git/t/t4013/diff.diff_-U1_initial..side, branch v2.22.0Fork of git SCM with my patches.http://git.kilabit.info/git/atom?h=v2.22.02019-05-29T18:04:32Zdiff-parseopt: restore -U (no argument) behavior2019-05-29T18:04:32ZNguyễn Thái Ngọc Duypclouds@gmail.com2019-05-29T09:11:15Zurn:sha1:8ef05193bcdda6a28cd41fa3ecd8f356061d49e0
Before d473e2e0e8 (diff.c: convert -U|--unified, 2019-01-27), -U and
--unified are implemented with a custom parser opt_arg() in diff.c. I
didn't check this code carefully and not realize that it's the
equivalent of PARSE_OPT_NONEG | PARSE_OPT_OPTARG.
In other words, if -U is specified without any argument, the option
should be accepted, and the default value should be used. Without
PARSE_OPT_OPTARG, parse_options() will reject this case and cause a
regression.
Reported-by: Bryan Turner <bturner@atlassian.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>