git/refs/ref-cache.h, branch gitk-resize-error

Merge branch 'jt/no-abuse-alternate-odb-for-submodules'

2021-10-25T23:06:56Z

Follow through the work to use the repo interface to access submodule objects in-process, instead of abusing the alternate object database interface. * jt/no-abuse-alternate-odb-for-submodules: submodule: trace adding submodule ODB as alternate submodule: pass repo to check_has_commit() object-file: only register submodule ODB if needed merge-{ort,recursive}: remove add_submodule_odb() refs: peeling non-the_repository iterators is BUG refs: teach arbitrary repo support to iterators refs: plumb repo into ref stores

refs: peeling non-the_repository iterators is BUG

2021-10-08T22:06:06Z

There is currently no support for peeling the current ref of an iterator iterating over a non-the_repository ref store, and none is needed. Thus, for now, BUG() if that happens. Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano

refs/ref-cache.[ch]: remove "incomplete" from create_dir_entry()

2021-09-28T22:12:04Z

Remove the now-unused "incomplete" parameter from create_dir_entry(), all its callers specify it as "1", so let's drop the "incomplete=0" case. The last caller to use it was search_for_subdir(), but that code was removed in the preceding commit. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano

refs/ref-cache.[ch]: remove unused add_ref_entry()

2021-09-28T22:12:04Z

This function has not been used since 9dd389f3d8d (packed_ref_store: get rid of the `ref_cache` entirely, 2017-09-25). Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano

refs/ref-cache.[ch]: remove unused remove_entry_from_dir()

2021-09-28T22:12:04Z

This function was missed in 9939b33d6a3 (packed-backend: rip out some now-unused code, 2017-09-08), and has been orphaned since then. Let's delete it. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano

refs/ref-cache.h: add missing declarations (hdr-check)

2018-09-20T18:50:00Z

Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano

ref_cache: remove support for storing peeled values

2017-09-25T09:02:46Z

Now that the `packed-refs` backend doesn't use `ref_cache`, there is nobody left who might want to store peeled values of references in `ref_cache`. So remove that feature. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

ref_iterator: keep track of whether the iterator output is ordered

2017-09-14T06:19:07Z

References are iterated over in order by refname, but reflogs are not. Some consumers of reference iteration care about the difference. Teach each `ref_iterator` to keep track of whether its output is ordered. `overlay_ref_iterator` is one of the picky consumers. Add a sanity check in `overlay_ref_iterator_begin()` to verify that its inputs are ordered. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

create_ref_entry(): remove `check_name` option

2017-05-23T05:29:56Z

Only one caller was using it, so move the check to that caller. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano

read_packed_refs(): do more of the work of reading packed refs

2017-05-23T05:29:55Z

Teach `read_packed_refs()` to also * Allocate and initialize the new `packed_ref_cache` * Open and close the `packed-refs` file * Update the `validity` field of the new object This decreases the coupling between `packed_refs_cache` and `files_ref_store` by a little bit. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano